OpenStack Shared File Systems Service (Manila)

Share is writable during host-assisted migration

Bug #1626523 reported by Rodrigo Barbieri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Rodrigo Barbieri
OpenStack Shared File Systems Service (Manila) ocata-2 "O2"

Bug Description

Share should remain read-only during migration. For drivers which update access rules always in recovery mode, the share access is being reverted to RW during migration.

Steps to reproduce:

1) Create a share on a backend running a driver that implements update_access always in recovery mode
2) Add a RW rule to give access to a VM
3) Mount the share in that VM
4) Write some data, confirming it is writable
5) Start a migration of that share
6) If you are quick enough, try to write some data in the share to confirm it is read only
7) During copy (watch m-dat or share's task_state through 'share show' or 'migration-get-progress'), try to write data to the share again, it will be writable <== BUG

Rodrigo Barbieri (rodrigo-barbieri2010)
Changed in manila:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
importance: Undecided → High
milestone: none → ocata-1
tags: added: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/375047

Changed in manila:
status: New → In Progress
Valeriy Ponomaryov (vponomaryov)
Changed in manila:
milestone: ocata-1 → ocata-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/375047
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ec0cda28cd3399a312cc28a58b13a1ff3891fad1
Submitter: Jenkins
Branch: master

commit ec0cda28cd3399a312cc28a58b13a1ff3891fad1
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Nov 28 15:15:42 2016 -0200

    Fix share writable in host-assisted migration

    For drivers that implement update_access always through recovery
    mode, access rules previously set to read-only were being reset
    to read-write when the Data Service was adding/removing its access
    rule.

    Fixed it by integrating the logic that casts DB rules to read-only
    into access helper class.

    Change-Id: Ife35dcdb99dffa2f266b5c2f6a68fe163da7edd3
    Closes-bug: #1626523

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/404700

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/newton)

Reviewed: https://review.openstack.org/404700
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=08779adc7a38692f1a461f45a84ee29d734b7d93
Submitter: Jenkins
Branch: stable/newton

commit 08779adc7a38692f1a461f45a84ee29d734b7d93
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Nov 28 15:15:42 2016 -0200

    Fix share writable in host-assisted migration

    For drivers that implement update_access always through recovery
    mode, access rules previously set to read-only were being reset
    to read-write when the Data Service was adding/removing its access
    rule.

    Fixed it by integrating the logic that casts DB rules to read-only
    into access helper class.

    (cherry-picked from commit ec0cda28cd3399a312cc28a58b13a1ff3891fad1)

    Change-Id: Ia24b95539b1917cc8a6623f98ab3ecd81b0942b2
    Closes-bug: #1626523

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 4.0.0.0b2

This issue was fixed in the openstack/manila 4.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.