NetApp cDOT driver should respect reserved_share_percentage

Bug #1561704 reported by Clinton Knight
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Clinton Knight

Bug Description

There is a common manila.conf parameter 'reserved_share_percentage' that may be set for each backend, and (if desired) it is the driver's responsibility to read this value and report it to the scheduler for each pool. The NetApp cDOT driver has never honored this value, but it should.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/301710

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/302628

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/301710
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f56d2fda973cfa3d45e19f18ea2a057b8a9438fd
Submitter: Jenkins
Branch: master

commit f56d2fda973cfa3d45e19f18ea2a057b8a9438fd
Author: Clinton Knight <email address hidden>
Date: Thu Mar 24 15:19:10 2016 -0400

    NetApp cDOT driver should honor reserved percentage

    There is a common manila.conf parameter 'reserved_share_percentage'
    that may be set for each backend, and (if desired) it is the
    driver's responsibility to read this value and report it to the
    scheduler for each pool. The NetApp cDOT driver has never honored
    this value, but it should. This commit makes this change, and it
    removes a couple extraneous capacity fields from the share stats.

    Change-Id: Ice52926033e5fd1fd787b71b0e98adccc1a2cbdc
    Closes-Bug: #1561704

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 3.0.0.0b1

This issue was fixed in the openstack/manila 3.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/mitaka)

Reviewed: https://review.openstack.org/302628
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=29431dfda862d5952449548a32c7e85bc8893bea
Submitter: Jenkins
Branch: stable/mitaka

commit 29431dfda862d5952449548a32c7e85bc8893bea
Author: Clinton Knight <email address hidden>
Date: Thu Mar 24 15:19:10 2016 -0400

    NetApp cDOT driver should honor reserved percentage

    There is a common manila.conf parameter 'reserved_share_percentage'
    that may be set for each backend, and (if desired) it is the
    driver's responsibility to read this value and report it to the
    scheduler for each pool. The NetApp cDOT driver has never honored
    this value, but it should. This commit makes this change, and it
    removes a couple extraneous capacity fields from the share stats.

    Change-Id: Ice52926033e5fd1fd787b71b0e98adccc1a2cbdc
    Closes-Bug: #1561704
    (cherry picked from commit f56d2fda973cfa3d45e19f18ea2a057b8a9438fd)

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.