scheduler choose wrong pool

Bug #1536936 reported by zhaohua
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
zhaohua

Bug Description

Consider the following scenario:
1. A pool reports it's capability "thin_provision=[True, False]", "max_over_subscription_ratio=20";
2.The free capacity of the pool is 1GB;
3.Create a share with size=5GB, share type contain "capabilities:thin_provision=<is> False"

The scheduler will choose this pool to create the 5GB share, but the free capacity is only 1GB.
The reason of this failure is that the scheduler will multiply free capacity by max_over_subscription_ratio when the capability of the pool contains "thin_provision=True". That means the pool is able to create 1x20=20GB thin share.

But in the scenario above, user want to create a share which is not thin.

So, maybe it's better to add a rule to the scheduler that the max_over_subscription_ratio is used ony the following two conditions are both met:
1. The capability of the pool contains "thin_provision=True";
2. The share type contains "capabilities:thin_provision=<is> True"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/271172

Changed in manila:
assignee: nobody → zhaohua (zhaohua-zhao)
status: New → In Progress
Changed in manila:
milestone: none → mitaka-rc1
importance: Undecided → Low
Changed in manila:
milestone: mitaka-rc1 → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by zhongjun (<email address hidden>) on branch: master
Review: https://review.openstack.org/271172
Reason: It has been resolved in https://review.openstack.org/#/c/367466/ and https://review.openstack.org/#/c/315266/

Tom Barron (tpb)
Changed in manila:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.