Mahara

Expiry/inactivity warnings try to email invalid addresses

Bug #903485 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Richard Mansfield
Mahara 1.5.0

Bug Description

The cron job to send account/institution expiry and inactivity warnings doesn't check for deleted users or invalid email addresses. If there's even one deleted user in the list, it will cause cron to die, so other users are never warned.

Tags: cron expiry
François Marier (fmarier)
Changed in mahara:
importance: Low → Medium
tags: added: cron
François Marier (fmarier)
tags: added: expiry
Revision history for this message
François Marier (fmarier) wrote :

https://reviews.mahara.org/#change,924

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/924
Committed: http://gitorious.org/mahara/mahara/commit/b47b62e18e7b1f49b006314ee9e65a0cf8fae993
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit b47b62e18e7b1f49b006314ee9e65a0cf8fae993
Author: Richard Mansfield <email address hidden>
Date: Tue Dec 13 12:38:48 2011 +1300

    Don't send expiry/inactivity warnings to deleted users (bug #903485)

    Users are emailed on cron to warn them about impending account expiry,
    inactivity, or institution membership expiry, but deleted users are
    included in the list, resulting in attempts to send email to invalid
    addresses.

    Change-Id: I5c95c927863330dc51aa632cc9aded75ea9b65e5
    Signed-off-by: Richard Mansfield <email address hidden>

François Marier (fmarier)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/925
Committed: http://gitorious.org/mahara/mahara/commit/01e17257e4ab439e6c19c5a73265ced6f19c279d
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 01e17257e4ab439e6c19c5a73265ced6f19c279d
Author: Richard Mansfield <email address hidden>
Date: Tue Dec 13 12:48:40 2011 +1300

    Notify internally when trying to warn users with invalid email (bug #903485)

    When expiry/inactivity warnings are sent, invalid email addresses
    throw exceptions, so the cron script will fail. It is better to catch
    the email exception and insert an internal notification instead. For
    account expiry/inactivity, it is unlikely that the user will ever read
    the warning, but it may be useful for institution membership expiry.

    Change-Id: Id264aa72fd31155a4b7889aa0e172b1ed7676e58
    Signed-off-by: Richard Mansfield <email address hidden>

Melissa Draper (melissa)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.