Upload form not hidden correctly based on group folder permissions

Bug #854377 reported by Richard Mansfield
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Richard Mansfield

Bug Description

When configuring a file block, the upload form should be hidden whenever the logged in user is browsing inside a group folder that s/he cannot edit. However, this doesn't happen correctly for the first folder you browse to when editing a group view, so if that first folder doesn't allow editing, the upload form is displayed anyway (though the user will get an error when trying to upload).

Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Richard Mansfield (richard-mansfield)
milestone: none → 1.5.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/714
Committed: http://gitorious.org/mahara/mahara/commit/1cf736c54a21b71f63e34010568ad6cbfbe231e0
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 1cf736c54a21b71f63e34010568ad6cbfbe231e0
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 20 14:27:28 2011 +1200

    Hide form when group file permissions doesn't allow upload (bug #854377)

    When configuring a file block, the upload form should be hidden
    whenever the logged in user is browsing inside a group folder that
    s/he cannot edit. However, this doesn't happen correctly for the first
    folder you browse to when editing a group view, so if that first
    folder doesn't allow editing, the upload form is displayed anyway.

    This occurs because the group id is not passed through along with the
    change folder command when you're editing a group view.

    Change-Id: Ife148dee1ec1908b10dd90cc28da1c962bff39a0
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqY0AAoJECXBtiziiXdcrpMIAKO5qOyhN9AQn9fCr32yAEba
wyQwhMOm1wS5eB4Qa29Hbr3c0xgXcwgsIFHfe0SCL92Gt2W3UjB8klrrRYssj5iu
o7DlmKBJhXo7i/AC005KeMTQZfY7ZX/tI8Lqux3FjfhSpRhCPatLLPr/hZHTbB4X
XXI47L8e304a6AwmDgsa9UUejDIjOwmOF7fFTeul8OgS4zSg3GUDQ1tTMW3+7Sns
YNmS3iU2+e0Z1CQlg5BqKwHVzCByuPPXuotvUkBkcLP53k1gUOn3OnMODTfbbrvf
UOVYo510SEKrkMCi0B4rLQHg8Ck2cUc1wS4GhxCOMrAcYDokjgTM98AerGB2sGE=
=uHSn
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.