Upload form not hidden correctly based on group folder permissions
Bug #854377 reported by
Richard Mansfield
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Richard Mansfield |
Bug Description
When configuring a file block, the upload form should be hidden whenever the logged in user is browsing inside a group folder that s/he cannot edit. However, this doesn't happen correctly for the first folder you browse to when editing a group view, so if that first folder doesn't allow editing, the upload form is displayed anyway (though the user will get an error when trying to upload).
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Richard Mansfield (richard-mansfield) |
milestone: | none → 1.5.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/714 gitorious. org/mahara/ mahara/ commit/ 1cf736c54a21b71 f63e34010568ad6 cbfbe231e0
Committed: http://
Submitter: Richard Mansfield (<email address hidden>)
Branch: master
commit 1cf736c54a21b71 f63e34010568ad6 cbfbe231e0
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 20 14:27:28 2011 +1200
Hide form when group file permissions doesn't allow upload (bug #854377)
When configuring a file block, the upload form should be hidden
whenever the logged in user is browsing inside a group folder that
s/he cannot edit. However, this doesn't happen correctly for the first
folder you browse to when editing a group view, so if that first
folder doesn't allow editing, the upload form is displayed anyway.
This occurs because the group id is not passed through along with the
change folder command when you're editing a group view.
Change-Id: Ife148dee1ec190 8b10dd90cc28da1 c962bff39a0
Signed-off-by: Richard Mansfield <email address hidden>