Don't check internal auth instances for automatic user creation
Bug #850617 reported by
Richard Mansfield
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Richard Mansfield |
Bug Description
When a user logs in with an unknown username, all the authinstances on the site are checked one by one, with separate queries, to see if they want to create the user automatically. It's easy to restrict the check to non-internal authinstances, and cuts out a lot of useless work because internal authinstances can never automatically create users.
Changed in mahara: | |
assignee: | nobody → Richard Mansfield (richard-mansfield) |
importance: | Undecided → Low |
milestone: | none → 1.5.0 |
status: | New → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
Reviewed: https:/ /reviews. mahara. org/696 gitorious. org/mahara/ mahara/ commit/ e98b352e2e1f209 f3353ed8f2f0050 edce27c527
Committed: http://
Submitter: Richard Mansfield (<email address hidden>)
Branch: master
commit e98b352e2e1f209 f3353ed8f2f0050 edce27c527
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 15 17:22:22 2011 +1200
Skip checks of internal authinstances when auto-creating users (bug #850617)
Change-Id: I31b8d70169e366 5167f50f06d07ce 263b33464e5
Signed-off-by: Richard Mansfield <email address hidden>