Mahara

Missing Plugins Should be disabled automatically

Bug #824445 reported by Andrew Nicols
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Andrew Nicols
Mahara 1.5.0

Bug Description

If a plugin has been installed, but then goes away (e.g. it is moved or the user wants to uninstall it by removing the plugin directory), this can cause various frustrations and site issues (unrecoverable error) which prevent all users from using any plugin.

We should attempt to handle at least the base issue - a plugin going away should not break use of every other plugin.

I've written a patch which wraps safe_require. This disables the plugin and alerts administrators of the issue.

Andrew Nicols (dobedobedoh)
Changed in mahara:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Andrew Nicols (dobedobedoh)
Andrew Nicols (dobedobedoh)
Changed in mahara:
milestone: none → 1.5.0
Revision history for this message
Andrew Nicols (dobedobedoh) wrote :

Fix committed in Change 578 - awaiting review

Revision history for this message
Andrew Nicols (dobedobedoh) wrote :

Updated to catch a missing case. Awaiting review

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/578
Committed: http://gitorious.org/mahara/mahara/commit/0a694de54c37f00e8c2c826f46f319a59e9bb0a8
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 0a694de54c37f00e8c2c826f46f319a59e9bb0a8
Author: Andrew Robert Nicols <email address hidden>
Date: Thu Aug 11 11:54:48 2011 +0100

    Bug #824445: Improve error reporting for missing plugins

    This set of changes attempts to handle missing plugins in a better fashion.
    Rather than throwing an uncaught error which causes a unrecoverable site
    error, which in turn means that no user can use any other plugin; this
    patch disables the problem plugin and informs administrators of the issue.

    To handle the case where core plugins, which under normal circumstances
    cannot be disabled, are missing and disabled; the plugins.tpl template is
    also changed to test for the contents of the activateform, instead of
    whether the plugin can ordinarily be disabled. This means that if the issue
    is then fixed, the plugin can once again be re-enabled, at which point the
    [ hide ] link will no longer appear.

    Change-Id: I6f9fa73ae0ac307b5f5f8f30b8205690926f54fc
    Signed-off-by: Andrew Robert Nicols <email address hidden>

François Marier (fmarier)
Changed in mahara:
status: In Progress → Fix Committed
Dominique-Alain JAN (dajan)
tags: added: newfeature
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrXHAAoJECXBtiziiXdcU94IALII/v8XTSOgD0jBkOXYzDms
uLkrvC+Z5YqYhQVjIR5cVYg7X3SJPUjuaorS2uVVfIkGlz+38KdZdczOYV+JaNQV
S8aVo/Rqrsx8h6fKtVAgTl8bd1CCMos1YnrOTNvqoYSOV2iGSSX/paQf6R9BjDbz
hx6GM7pkUp/gOa3Zqo+E6NfUrMWASanjbh9kbHdm09L7/10f7a5Q9w2Cf5o1yjC7
xqM9hEbPe32C9tBBcXDGPzQDFpJ6b6Rys2dzt6NTNkv2FCyzKS4RLwGDUDRNBEEZ
iYxQ5wJJaxW+/RO8k4lGYSo7Mtt99aIxhkQX7DKxcEoOSNMdPUi9ptwjolgG4iI=
=AeF+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.