Unit tests should not perform logging,but some tests still use

Bug #1600109 reported by jingtao liang
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
jingtao liang
Glance
Invalid
Undecided
weiweigu
Glance Client
Invalid
Undecided
Unassigned
Magnum
Incomplete
Undecided
hongzhezheng
OpenStack Compute (nova)
Invalid
Undecided
Bin Zhou
OpenStack DBaaS (Trove)
Invalid
Undecided
Unassigned
OpenStack Identity (keystone)
Won't Fix
Undecided
Unassigned
OpenStack Object Storage (swift)
Invalid
Undecided
Unassigned
python-cinderclient
Invalid
Undecided
YaoZheng_ZTE
python-keystoneclient
Won't Fix
Undecided
Unassigned
python-novaclient
Invalid
Undecided
YaoZheng_ZTE
python-rackclient
Expired
Undecided
Unassigned
python-swiftclient
Incomplete
Undecided
hongzhezheng
rack
Expired
Undecided
Unassigned

Bug Description

We shuld remove the logging

Changed in cinder:
assignee: nobody → jingtao liang (liang-jingtao)
Changed in glance:
assignee: nobody → weiweigu (gu-weiwei)
Yafei Yu (yu-yafei)
Changed in os-brick:
assignee: nobody → yuyafei (yu-yafei)
Changed in rally:
assignee: nobody → yuyafei (yu-yafei)
Changed in glance-store:
assignee: nobody → yuyafei (yu-yafei)
Changed in python-glanceclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Changed in python-cinderclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Changed in python-novaclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Yafei Yu (yu-yafei)
Changed in neutron:
assignee: nobody → yuyafei (yu-yafei)
Changed in tempest:
assignee: nobody → yuyafei (yu-yafei)
Ji.Wei (jiwei)
Changed in swift:
assignee: nobody → Ji.Wei (jiwei)
Yafei Yu (yu-yafei)
Changed in python-heatclient:
assignee: nobody → yuyafei (yu-yafei)
Ji.Wei (jiwei)
Changed in keystone:
assignee: nobody → Ji.Wei (jiwei)
Bin Zhou (binzhou)
Changed in nova:
assignee: nobody → Bin Zhou (binzhou)
Changed in ceilometer:
assignee: nobody → Bin Zhou (binzhou)
Ji.Wei (jiwei)
Changed in nova:
assignee: Bin Zhou (binzhou) → Ji.Wei (jiwei)
assignee: Ji.Wei (jiwei) → nobody
Bin Zhou (binzhou)
Changed in rack:
assignee: nobody → Bin Zhou (binzhou)
Ji.Wei (jiwei)
Changed in rack:
assignee: Bin Zhou (binzhou) → Ji.Wei (jiwei)
Bin Zhou (binzhou)
Changed in nova:
assignee: nobody → Bin Zhou (binzhou)
Ji.Wei (jiwei)
Changed in python-rackclient:
assignee: nobody → Ji.Wei (jiwei)
Changed in magnum:
assignee: nobody → hongzhezheng (zheng-hongzhe32)
Changed in python-swiftclient:
assignee: nobody → hongzhezheng (zheng-hongzhe32)
Changed in python-keystoneclient:
assignee: nobody → hongzhezheng (zheng-hongzhe32)
Ji.Wei (jiwei)
Changed in python-keystoneclient:
assignee: hongzhezheng (zheng-hongzhe32) → Ji.Wei (jiwei)
haobing1 (haobing1)
Changed in trove:
assignee: nobody → haobing1 (haobing1)
Changed in python-neutronclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Revision history for this message
Amrith Kumar (amrith) wrote :

Without more details about this, it is hard to tell what this bug is about. How can code not perform logging just because it is in unit tests? Heck, some tests actually verify that messages are being logged.

Changed in trove:
status: New → Opinion
Revision history for this message
Brant Knudson (blk-u) wrote :

What problem is this causing?

Changed in python-keystoneclient:
status: New → Incomplete
David Stanek (dstanek)
Changed in keystone:
status: New → Incomplete
Revision history for this message
Dolph Mathews (dolph) wrote :

> Unit tests should not perform logging

Why not? Debugging is useful.

Changed in ceilometer:
status: New → Incomplete
Revision history for this message
Amrith Kumar (amrith) wrote :

marking incomplete for Trove per IRC chat with keystone folks.

Changed in trove:
status: Opinion → Incomplete
Dolph Mathews (dolph)
Changed in cinder:
status: New → Incomplete
Changed in glance:
status: New → Incomplete
Changed in magnum:
status: New → Incomplete
Changed in nova:
status: New → Incomplete
Changed in swift:
status: New → Incomplete
Dolph Mathews (dolph)
Changed in rally:
status: New → Incomplete
Changed in glance-store:
status: New → Incomplete
Changed in neutron:
status: New → Incomplete
Changed in os-brick:
status: New → Incomplete
Changed in python-cinderclient:
status: New → Incomplete
Dolph Mathews (dolph)
Changed in python-glanceclient:
status: New → Incomplete
Changed in python-heatclient:
status: New → Incomplete
Changed in python-neutronclient:
status: New → Incomplete
Changed in python-novaclient:
status: New → Incomplete
Changed in python-rackclient:
status: New → Incomplete
Changed in python-swiftclient:
status: New → Incomplete
Changed in rack:
status: New → Incomplete
Changed in tempest:
status: New → Incomplete
Revision history for this message
Dolph Mathews (dolph) wrote :

Without any presenting any reasoning or justification, this "bug" seems opinionated, wasteful, and counter-productive.

Revision history for this message
Ian Cordasco (icordasc) wrote :

I have to agree with Dolph. I'm inclined to mark it as "won't fix" for glance.

Revision history for this message
jingtao liang (liang-jingtao) wrote :

@Dolph Mathews (dolph) Ian Cordasco (icordasc)

Hello, i'm sorry to give the reason here so later.But in the cinder HACKING.rst,you can see the Cinder Specific Commandments [C309].You will see :Unit tests should not perform logging.

Revision history for this message
David Stanek (dstanek) wrote :

Marking as WONTFIX for now because I don't think this is a keystone issue at all. If you find a place in keystone where there is a problem feel free to reopen.

Changed in keystone:
status: Incomplete → Won't Fix
Changed in python-keystoneclient:
status: Incomplete → Won't Fix
Yafei Yu (yu-yafei)
Changed in os-brick:
assignee: yuyafei (yu-yafei) → nobody
no longer affects: os-brick
no longer affects: python-heatclient
no longer affects: neutron
no longer affects: rally
no longer affects: glance-store
no longer affects: tempest
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

Nova has no rules in place which forbids that, so it's not a bug. I also don't see a reason to put effort into this.

Changed in nova:
status: Incomplete → Invalid
Changed in python-novaclient:
status: Incomplete → Invalid
Revision history for this message
Amrith Kumar (amrith) wrote :

This is not a bug (in Trove).

Changed in trove:
assignee: haobing1 (haobing1) → nobody
status: Incomplete → Invalid
Changed in cinder:
status: Incomplete → Invalid
Changed in python-cinderclient:
status: Incomplete → Invalid
gordon chung (chungg)
no longer affects: ceilometer
Akihiro Motoki (amotoki)
no longer affects: python-neutronclient
Tim Burke (1-tim-z)
Changed in swift:
assignee: Ji.Wei (jiwei) → nobody
status: Incomplete → Invalid
Ji.Wei (jiwei)
Changed in rack:
assignee: Ji.Wei (jiwei) → nobody
Changed in python-rackclient:
assignee: Ji.Wei (jiwei) → nobody
Changed in keystone:
assignee: Ji.Wei (jiwei) → nobody
Changed in python-keystoneclient:
assignee: Ji.Wei (jiwei) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for rack because there has been no activity for 60 days.]

Changed in rack:
status: Incomplete → Expired
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for python-rackclient because there has been no activity for 60 days.]

Changed in python-rackclient:
status: Incomplete → Expired
Revision history for this message
Cyril Roelandt (cyril-roelandt) wrote :

This does not seem relevant to Glance.

Changed in python-glanceclient:
assignee: YaoZheng_ZTE (zheng-yao1) → nobody
status: Incomplete → Invalid
Changed in glance:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.