Magnum

Rename "external_network_id" to "external_network"

Bug #1540126 reported by hongbin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
In Progress
Low
yatin

Bug Description

This has been discussed in the review https://review.openstack.org/#/c/270620/4 . Baymodel has an attribute called "external_network_id". The name is not accurate, since we can specify the network name as well (see below). Therefore, we should rename it to "external_network" (removing "_id").

magnum baymodel-create --name k8sbaymodel \
                       --image-id fedora-21-atomic-5 \
                       --keypair-id testkey \
                       --external-network-id public \
                       --dns-nameserver 8.8.8.8 \
                       --flavor-id m1.small \
                       --docker-volume-size 5 \
                       --network-driver flannel \
                       --coe kubernetes

hongbin (hongbin034)
tags: added: low-hanging-fruit
HouMing Wang (houming-wang)
Changed in magnum:
assignee: nobody → HouMing Wang (houming-wang)
Prithiv (prithiv)
Changed in magnum:
assignee: HouMing Wang (houming-wang) → Prithiv (prithiv)
assignee: Prithiv (prithiv) → nobody
assignee: nobody → Prithiv (prithiv)
Satwant Kaur (sept1mannu)
Changed in magnum:
assignee: Prithiv (prithiv) → Satwant Kaur (sept1mannu)
assignee: Satwant Kaur (sept1mannu) → nobody
Prithiv (prithiv)
Changed in magnum:
assignee: nobody → Prithiv (prithiv)
Deeksha Sachdeva (sachdevadeeksha5)
Changed in magnum:
assignee: Prithiv (prithiv) → Deeksha Sachdeva (sachdevadeeksha5)
Prithiv (prithiv)
Changed in magnum:
assignee: Deeksha Sachdeva (sachdevadeeksha5) → Prithiv (prithiv)
FNU SUDARSHAN (siddevelop)
Changed in magnum:
assignee: Prithiv (prithiv) → FNU SUDARSHAN (siddevelop)
FNU SUDARSHAN (siddevelop)
Changed in magnum:
assignee: FNU SUDARSHAN (siddevelop) → nobody
Prithiv (prithiv)
Changed in magnum:
assignee: nobody → Prithiv (prithiv)
Sharat Sharma (sharat-sharma)
Changed in magnum:
assignee: Prithiv (prithiv) → Sharat Sharma (sharat-sharma)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314529

Revision history for this message
yatin (yatinkarel) wrote :

@Sharat are you still working on this, if not I want to try fix this. I have also filed a bug for client as well: https://bugs.launchpad.net/python-magnumclient/+bug/1599393

yatin (yatinkarel)
Changed in magnum:
assignee: Sharat Sharma (sharat-sharma) → yatin (yatinkarel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/346122

Tom Cammann (tom-cammann)
Changed in magnum:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by yatin (<email address hidden>) on branch: master
Review: https://review.openstack.org/346122
Reason: Will continue after "bay to cluster" conversion

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Adrian Otto (<email address hidden>) on branch: master
Review: https://review.openstack.org/314529
Reason: Abandoning this patch because it is in merge conflict without a revision in one full week. You may un-abandon it, and post a revision at any time.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.