Magnum

consolidate heat fragments

Bug #1517218 reported by Daneyon Hansen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Committed
Medium
rajiv

Bug Description

Currently, duplicate fragments exist among the bay types. Duplicate fragments should be moved to a /magnum/templates/common DIR structure. Heat yaml's should be updated to point to this common DIR structure.

Tags: tech-debt
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
Eli Qiao (taget-9)
Changed in magnum:
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → Triaged
rajiv (rajiv-kumar)
Changed in magnum:
assignee: nobody → rajiv (rajiv-kumar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/346209

Changed in magnum:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/346209
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=4eca907f27e47e7f994800121c46d4f47c47f5bb
Submitter: Jenkins
Branch: master

commit 4eca907f27e47e7f994800121c46d4f47c47f5bb
Author: Rajiv Kumar <email address hidden>
Date: Fri Jul 22 15:13:43 2016 -0400

    Consolidate heat fragments

    In this change only configure_docker_registery.sh file has been
    removed for fedora atomic k8s, coreos k8s and fedora atomic swarm
    driver and put into the common.

    Change-Id: Ic905ce3807483e14ab04d4d3c1e07aa1d0dbda4f
    Closes-Bug: #1517218

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/349173

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

Spyros Trigazis (strigazi)
Changed in magnum:
status: Fix Released → In Progress
milestone: mitaka-1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/349173
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=0f6b3b6a389e096f13d97ea8fd9eed015f788f7d
Submitter: Jenkins
Branch: master

commit 0f6b3b6a389e096f13d97ea8fd9eed015f788f7d
Author: Rajiv Kumar <email address hidden>
Date: Sat Jul 30 13:19:19 2016 +0530

    Consolidate configure docker storage fragments

    In this commit configure-docker-storage.sh file has been removed
    from k8s coreos, fedora and swarm driver and put at the common
    location to avoid duplicacy and redundancy of code.

    Partial-bug: #1517218
    Change-Id: Ie467c1691cc148435da47448d31c35e7a1865984

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/365440

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/365440
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=cafda5620d576e4d16e542d152a317b7af9a3d48
Submitter: Jenkins
Branch: master

commit cafda5620d576e4d16e542d152a317b7af9a3d48
Author: Rajiv Kumar <email address hidden>
Date: Mon Sep 5 10:30:27 2016 +0530

    Consolidate enable docker registery fragments

    In this commit enable-docker-registery.sh file has been removed
    from k8s fedora and swarm driver and put at the common location
    to avoid duplicacy and redundancy of code.

    Change-Id: I6f3bb301fa46452745c770332a8083fd65b8a561
    Partial-bug: 1517218

Revision history for this message
Spyros Trigazis (strigazi) wrote :

A great deal of common code now lives in the common directory. Additionally, all common networking heat templates live in common too as well. If there is a new possible factor-out we can open another bug.

Changed in magnum:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.