Magento OpenERP Connector

Adapt to API change in base_external_referentials

Bug #1089266 reported by Stefan Rijnhart (Opener) on 2012-12-12

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Magento OpenERP Connector	Confirmed	High	Sébastien BEAU - http://www.akretion.com

Bug Description

Hi,

revision http://bazaar.launchpad.net/~extra-addons-commiter/openobject-extension/oerp6.1-stable/revision/215 changes the signature for extid_to_existing_oeid() as follows:

< def extid_to_existing_oeid(self, cr, uid, external_id, referential_id, context=None):
> def extid_to_existing_oeid(self, cr, uid, referential_id, external_id, context=None):

Judging by the branch name, you would expect lp:magentoerpconnect/oerp6.1-stable to adapt to this API change but this is not the case. Even the trunk branch of this project still contains a number calls with the arguments in the old order. See [1] for an example.

Cheers,
Stefan.

[1] http://bazaar.launchpad.net/~magentoerpconnect-core-editors/magentoerpconnect/trunk/view/664/magentoerpconnect/product.py#L230

Related branches

lp://staging/~therp-nl/magentoerpconnect/61stable-lp1089266-api_change

Ready for review for merging into lp://staging/magentoerpconnect/oerp6.1-stable

Sébastien BEAU - http://www.akretion.com: Needs Fixing on 2013-04-22

Guewen Baconnier @ Camptocamp: Approve on 2013-04-12

lp://staging/~therp-nl/magentoerpconnect/61trunk-lp1089266-api_change

Ready for review for merging into lp://staging/~magentoerpconnect-core-editors/magentoerpconnect/oerp7.0-refactor

MagentoERPConnect core editors: Pending requested 2012-12-12

lp://staging/~chafique-delli/+junk/magentoerpconnect

Revision history for this message

Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote on 2012-12-12:

Hello Stefan,

the oerp6.1-stable branch of the magento connector is not meant to use openobject-extension from extra-addons but from bzr+ssh://bazaar.launchpad.net/+branch/openobject-extension/oerp6.1-stable/

(the oerp6.1-oldstable branch still uses extra-addons).

Sorry for the confusion. I'm closing this bug as "invalid". Please reopen if I missed something.

Changed in magentoerpconnect:
status:	New → Invalid

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2012-12-12:

Hi Alexandre,

of course we are using this lp:openobject-extension/oerp6.1-stable, and this bug applies to it! As you can see on the Launchpad frontpage for this series [1], the exact branch from the revision I referred to is linked to it.

Reopening this bug, hope you understand.

Cheers,
Stefan.

[1] https://launchpad.net/openobject-extension/oerp6.1-stable