[2.3, HWTv2] Logs still sent with node object
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Medium
|
Lee Trager | ||
2.3 |
Fix Committed
|
Medium
|
Unassigned |
Bug Description
Previously MAAS sent almost all data about a node over the node websocket. This meant loading the node-details page took a large amount of data just to see basic information. With MAAS 2.3 the node-details page only loads the commissioning or testing results as needed speeding up page load time while decreasing the amount of bandwidth needed.
The logs(seen on the logs tab) are still being sent with the node object. Using a VM with no LLDP data found and minimal lshw data requires the following amount of bandwidth and memory.
node.summary_yaml: 37056B
node.summary_xml: 29548B
node.installati
Total: 79KB
Like commissioning and testing results node log data should only be loaded as needed. Because the summary_yaml and summary_xml are the combination of the lshw and lldp commissioning results using the current node-results websocket isn't possible. A new method should be added to the node websocket, getSummary, which will return the summary in the requested form. This data should only be sent when needed and no longer always sent with the node object.
Related branches
- Blake Rouse (community): Approve
-
Diff: 358 lines (+95/-54)6 files modifiedsrc/maasserver/websockets/base.py (+8/-6)
src/maasserver/websockets/handlers/device.py (+9/-1)
src/maasserver/websockets/handlers/machine.py (+0/-11)
src/maasserver/websockets/handlers/node.py (+30/-25)
src/maasserver/websockets/handlers/tests/test_device.py (+1/-1)
src/maasserver/websockets/handlers/tests/test_machine.py (+47/-10)
- Blake Rouse (community): Approve
-
Diff: 949 lines (+436/-308)7 files modifiedsrc/maasserver/static/js/angular/controllers/node_details.js (+0/-125)
src/maasserver/static/js/angular/controllers/node_results.js (+141/-11)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+1/-145)
src/maasserver/static/js/angular/controllers/tests/test_node_results.js (+230/-0)
src/maasserver/static/js/angular/factories/nodes.js (+13/-1)
src/maasserver/static/js/angular/factories/tests/test_nodes.js (+32/-0)
src/maasserver/static/partials/node-details.html (+19/-26)
- Blake Rouse (community): Approve
- Alberto Donato: Approve
-
Diff: 512 lines (+104/-236)5 files modifiedsrc/maasserver/websockets/handlers/controller.py (+3/-1)
src/maasserver/websockets/handlers/machine.py (+3/-1)
src/maasserver/websockets/handlers/node.py (+53/-93)
src/maasserver/websockets/handlers/switch.py (+4/-1)
src/maasserver/websockets/handlers/tests/test_machine.py (+41/-140)
- Blake Rouse (community): Approve
- MAAS Lander: Approve
-
Diff: 949 lines (+436/-308)7 files modifiedsrc/maasserver/static/js/angular/controllers/node_details.js (+0/-125)
src/maasserver/static/js/angular/controllers/node_results.js (+141/-11)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+1/-145)
src/maasserver/static/js/angular/controllers/tests/test_node_results.js (+230/-0)
src/maasserver/static/js/angular/factories/nodes.js (+13/-1)
src/maasserver/static/js/angular/factories/tests/test_nodes.js (+32/-0)
src/maasserver/static/partials/node-details.html (+19/-26)
- Blake Rouse (community): Approve
- MAAS Lander: Needs Fixing
- Andres Rodriguez (community): Needs Fixing
-
Diff: 512 lines (+104/-236)5 files modifiedsrc/maasserver/websockets/handlers/controller.py (+3/-1)
src/maasserver/websockets/handlers/machine.py (+3/-1)
src/maasserver/websockets/handlers/node.py (+53/-93)
src/maasserver/websockets/handlers/switch.py (+4/-1)
src/maasserver/websockets/handlers/tests/test_machine.py (+41/-140)
Changed in maas: | |
milestone: | 2.3.0beta3 → 2.3.0beta4 |
Changed in maas: | |
milestone: | 2.3.0beta4 → 2.3.0rc1 |
tags: | added: performance |
Changed in maas: | |
milestone: | 2.3.0rc1 → 2.3.0rc2 |
Changed in maas: | |
milestone: | 2.3.0rc2 → 2.4.x |
tags: | added: ui |
Changed in maas: | |
assignee: | nobody → Lee Trager (ltrager) |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.4.x → 2.4.0alpha2 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
no longer affects: | maas/2.6 |