Grouped machine list view: Inconsistent display when machine state changes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Peter Makowski | ||
3.3 |
Fix Released
|
Critical
|
Peter Makowski | ||
maas-ui |
Fix Released
|
Critical
|
Bug Description
Due to the switch to server side filtering and grouping the situation described in this frontend issue can occur:
https:/
------%<--- for reference -------
Steps to reproduce the behavior:
* Go to machine listing
* Ensure machines are grouped by status
* Select a machine that has failed commissioning
* Begin commissioning the machine
* Machine remains grouped under "Failed commissioning" even though status has changed to "Commissioning"
Expected behavior
* When "Group by status" is selected on the machine list and a machine changes status, the machine in question is regrouped under its new status.
------%
The above feels very wrong and it is unclear how to go forward.
Option 1: Accept that and do nothing.
Option 2: Move the machine to the group where it belongs after the status change. If this group is currently not shown in the list, we have
Option 2.1: Accept that and do nothing
Option 2.2: Create that new group and move the machine there.
Option 3: (was discussed in an older version of the spec) Show a hint that inconsistent/weird things happened in the list and ask the user to re-fetch the data.
Option 3a: Also mark the items that changes status somehow (e.g. color) to be clear which weird things happened.
(this list might not be exhaustive, open for other solution ideas)
Independent of the option we chose this can be fixed in the frontend and/or in the backend. Fixing it in the frontend would however again move away from backend data being the source of truth and generate an inconsistent state. Also for Option 2.2. the frontend does not have the data how many machines are potentially in this group.
Changed in maas-ui: | |
status: | Unknown → New |
Changed in maas: | |
assignee: | nobody → Peter Makowski (petermakowski) |
Changed in maas: | |
status: | Triaged → Won't Fix |
status: | Won't Fix → Fix Released |
Changed in maas-ui: | |
importance: | Unknown → Undecided |
status: | New → Fix Released |
Changed in maas-ui: | |
importance: | Undecided → Critical |
Changed in maas: | |
status: | Fix Released → Fix Committed |
Changed in maas: | |
milestone: | 3.4.0 → 3.4.0-beta1 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
MAAS backend should notify the UI about a change in the requested information, and the UI would update the displayed information based on that notification (option 2.2). The UI would need to issue a new query with the currently shown IDs and ask for grouping, and backend would generate the current status. Requesting the original query again would not be optimal for UX because the operators expect to see the same set of machines when e.g. waiting for them to deploy.