Connection to local Vault fails if proxy is configured
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Adam Collard | ||
3.3 |
Fix Released
|
Critical
|
Adam Collard |
Bug Description
Given a MAAS installation which needs a proxy to reach the Internet, and a LAN accessible Vault installation, MAAS will erroneously try to reach the Vault server via the proxy.
This can be seen in the system-tests, with the addition of a logger.exception()
Traceback (most recent call last):
File "/usr/lib/
return func(*args, **kwargs)
File "/usr/lib/
self.
File "/usr/lib/
self.
File "/usr/lib/
return self._adapter.
File "/usr/lib/
response = self.post(url, **kwargs)
File "/usr/lib/
return self.request(
File "/usr/lib/
response = super(JSONAdapter, self).request(
File "/usr/lib/
response = self.session.
File "/usr/lib/
resp = self.send(prep, **send_kwargs)
File "/usr/lib/
r = adapter.
File "/usr/lib/
raise ProxyError(e, request=request)
requests.
nnection failed: 403 Forbidden')))
Related branches
- Adam Collard (community): Approve
-
Diff: 131 lines (+54/-27)3 files modifiedsrc/maasserver/bootsources.py (+1/-0)
src/maasserver/pytest_tests/test_vault.py (+47/-19)
src/maasserver/vault.py (+6/-8)
- MAAS Lander: Needs Fixing
- Alberto Donato: Approve
-
Diff: 131 lines (+54/-27)3 files modifiedsrc/maasserver/bootsources.py (+1/-0)
src/maasserver/pytest_tests/test_vault.py (+47/-19)
src/maasserver/vault.py (+6/-8)
- MAAS Lander: Approve
- Alberto Donato: Approve
- Christian Grabowski: Approve
-
Diff: 183 lines (+80/-13)3 files modifiedsrc/maasserver/bootsources.py (+36/-10)
src/maasserver/tests/test_bootresources.py (+1/-1)
src/maasserver/tests/test_bootsources.py (+43/-2)
- Adam Collard (community): Approve
-
Diff: 99 lines (+40/-2)2 files modifiedsrc/maasserver/pytest_tests/test_vault.py (+23/-0)
src/maasserver/vault.py (+17/-2)
- Jack Lloyd-Walters: Approve
- MAAS Lander: Approve
-
Diff: 99 lines (+40/-2)2 files modifiedsrc/maasserver/pytest_tests/test_vault.py (+23/-0)
src/maasserver/vault.py (+17/-2)
no longer affects: | maas/3.4 |
Changed in maas: | |
milestone: | none → 3.4.0 |
Changed in maas: | |
importance: | Undecided → Critical |
assignee: | nobody → Adam Collard (adam-collard) |
status: | New → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 3.4.0 → 3.4.0-beta1 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
The first fix was not sufficient, which isn't that surprising - the code for pulling in images is setting global environment variables that affect the whole process :/
Revised attempt (and still not a complete fix, but it's better) is in https:/ /code.launchpad .net/~adam- collard/ maas/+git/ maas/+merge/ 435387