"20-maas-03-machine-resources" commissioning script improperly reports a Pass when the test fails
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Björn Tillenius | ||
3.3 |
Fix Released
|
High
|
Björn Tillenius |
Bug Description
Hello,
As the summary states, the "20-maas-
---
root@star-ox:~# /tmp/user_
--2022-09-19 15:50:50-- http://
Connecting to 192.168.1.1:5248... connected.
HTTP request sent, awaiting response... 200 OK
Length: 6885376 (6.6M) [application/
Saving to: ‘/tmp/tmp.
/tmp/tmp.orVF15wxE2 100%[==
2022-09-19 15:50:50 (45.1 MB/s) - ‘/tmp/tmp.
ERROR: Failed to retrieve network information: Failed to add device information for "/sys/class/
---
It took me a while to get to this point since the interface was showing me a green checkmark, indicating that the test was successful.
I would recommend adding some return code checking to the "20-maas-
Thank you!
Related branches
- Björn Tillenius: Approve
-
Diff: 13 lines (+2/-0)1 file modifiedsrc/provisioningserver/refresh/20-maas-03-machine-resources (+2/-0)
- Christian Grabowski: Approve
-
Diff: 13 lines (+2/-0)1 file modifiedsrc/provisioningserver/refresh/20-maas-03-machine-resources (+2/-0)
Changed in maas: | |
milestone: | none → 3.4.0 |
status: | Triaged → In Progress |
assignee: | nobody → Björn Tillenius (bjornt) |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 3.4.0 → 3.4.0-beta1 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Able to confirm, encountered this while testing LP:1989974 as well.