MAAS

Add "clone" to machine actions websocket api

Bug #1938660 reported by Caleb Ellis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Adam Collard
MAAS 3.1.0-beta1

Bug Description

Project brief: https://docs.google.com/document/d/1Add3LO44zPRHTX04FnDuOwXAiKAZYC5ivtOBdXWqVGI/edit

In order to build the UI for machine network/storage cloning we need to be able to access the cloning API via the websocket. It should follow the same format as the other machine actions, i.e:

 - Machines returned from the machine.list method should include "clone" in data["actions"] if the machine can be cloned from.
 - The machine.action method should include params for the clone action and should work the same as the http API.
 - The general.machine_actions websocket method should return data about the "clone" action.

Related branches

~adam-collard/maas:clone-websocket-endpoint
Christian Grabowski: Approve
MAAS Lander: Approve
Diff: 247 lines (+165/-3)
4 files modified
src/maasserver/forms/clone.py (+6/-2)
src/maasserver/node_action.py (+32/-1)
src/maasserver/tests/test_node_action.py (+89/-0)
src/maasserver/websockets/handlers/tests/test_machine.py (+38/-0)
Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

This might be better served as a separate bug but the designs also call for grouping of errors returned from the clone action.

Alexsander de Souza (alexsander-souza)
tags: added: ui
tags: removed: ui
Adam Collard (adam-collard)
Changed in maas:
status: New → In Progress
assignee: nobody → Adam Collard (adam-collard)
Adam Collard (adam-collard)
Changed in maas:
importance: Undecided → High
MAAS Lander (maas-lander)
Changed in maas:
milestone: none → next
status: In Progress → Fix Committed
Revision history for this message
Adam Collard (adam-collard) wrote :

< {"method":"general.machine_actions","type":0,"request_id":26}

> {"type": 1, "request_id": 26, "rtype": 0, "result": [{"name": "commission", "title": "Commission...", "sentence": "commissioned", "type": "lifecycle"}, {"name": "acquire", "title": "Acquire...", "sentence": "acquired", "type": "lifecycle"}, {"name": "deploy", "title": "Deploy...", "sentence": "deployed", "type": "lifecycle"}, {"name": "on", "title": "Power on...", "sentence": "powered on", "type": "power"}, {"name": "off", "title": "Power off...", "sentence": "powered off", "type": "power"}, {"name": "release", "title": "Release...", "sentence": "released", "type": "lifecycle"}, {"name": "abort", "title": "Abort...", "sentence": "aborted", "type": "lifecycle"}, {"name": "test", "title": "Test...", "sentence": "tested", "type": "testing"}, {"name": "rescue-mode", "title": "Rescue mode...", "sentence": "rescue mode", "type": "testing"}, {"name": "exit-rescue-mode", "title": "Exit rescue mode...", "sentence": "exit rescue mode", "type": "testing"}, {"name": "mark-broken", "title": "Mark broken", "sentence": "marked broken", "type": "testing"}, {"name": "mark-fixed", "title": "Mark fixed", "sentence": "marked fixed", "type": "testing"}, {"name": "override-failed-testing", "title": "Override failed testing...", "sentence": "Override failed testing", "type": "testing"}, {"name": "lock", "title": "Lock", "sentence": "Lock", "type": "lock"}, {"name": "unlock", "title": "Unlock", "sentence": "Unlock", "type": "lock"}, {"name": "tag", "title": "Tag", "sentence": "tagged", "type": "misc"}, {"name": "clone", "title": "Clone", "sentence": "cloned", "type": "misc"}, {"name": "set-zone", "title": "Set zone...", "sentence": "Zone set", "type": "misc"}, {"name": "set-pool", "title": "Set resource pool...", "sentence": "Pool set", "type": "misc"}, {"name": "delete", "title": "Delete...", "sentence": "deleted", "type": "misc"}]}

Bill Wear (billwear)
Changed in maas:
milestone: next → 3.1.0-beta1
Bill Wear (billwear)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.