Websocket API: config.update should take list
Bug #1839788 reported by
Kit Randel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Committed
|
High
|
Adam Collard | ||
| maas-ui |
Fix Committed
|
High
|
Peter Makowski | ||
Bug Description
`config.update` should take a list, rather than a single key:value pair to allow for transactional updating of forms. Currently, we need to make a single request for every form element, and lose the ability to rollback updates if one or more updates fail.
Related branches
~adam-collard/maas:bulk-update-lp1839788
- Christian Grabowski: Approve
- MAAS Lander: Approve
-
Diff: 126 lines (+87/-1)2 files modifiedsrc/maasserver/websockets/handlers/config.py (+35/-1)
src/maasserver/websockets/handlers/tests/test_config.py (+52/-0)
| Changed in maas: | |
| status: | New → Incomplete |
| status: | Incomplete → Opinion |
| status: | Opinion → Triaged |
| importance: | Undecided → Wishlist |
Revision history for this message
| Thorsten Merten (thorsten-merten) wrote | #1 |
| Changed in maas: | |
| status: | Triaged → Incomplete |
| tags: | added: ui |
Revision history for this message
| Peter Makowski (petermakowski) wrote | #2 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in maas: | |
| status: | Incomplete → Expired |
| Changed in maas: | |
| status: | Expired → Triaged |
Revision history for this message
| Adam Collard (adam-collard) wrote | #4 |
| Changed in maas: | |
| importance: | Wishlist → High |
| milestone: | none → 3.4.0 |
| Changed in maas-ui: | |
| importance: | Undecided → High |
| milestone: | none → 3.4.0 |
| status: | New → Triaged |
| Changed in maas-ui: | |
| milestone: | 3.4.0 → 3.5.0 |
| no longer affects: | maas-ui/3.4 |
| Changed in maas: | |
| milestone: | 3.4.0 → 3.5.0 |
| Changed in maas: | |
| assignee: | nobody → Adam Collard (adam-collard) |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Peter Makowski (petermakowski) wrote | #5 |
| Changed in maas-ui: | |
| assignee: | nobody → Peter Makowski (petermakowski) |
| status: | Triaged → In Progress |
| Changed in maas-ui: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Is this issue still valid? We think that it should not be a problem in current versions anymore since the settings page has been reworked.