MAAS

[2.4, UI] Reenable broken Javascript tests

Bug #1750092 reported by Lee Trager on 2018-02-17

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	MAAS	Fix Released	Critical	Anthony Dillon	MAAS 2.4.0alpha2

Bug Description

8acf3b1 accidentally disabled all Javascript tests. I reenabled them in [1] but a number of tests failed due to the changes in 8acf3b1. I fixed what I could, the tests listed below were kept disabled as they are more complicated to fix and I wanted to get JS testing enabled again.

src/maasserver/static/js/angular/directives/tests/test_accordion.js
* sets a new active removing other actives

src/maasserver/static/js/angular/directives/tests/test_call_to_action.js
* All tests

src/maasserver/static/js/angular/directives/tests/test_code_lines.js
* All tests

src/maasserver/static/js/angular/directives/tests/test_controller_status.js
* sets serviceClass in the class for element

src/maasserver/static/js/angular/directives/tests/test_maas_obj_form.js
* All tests

[1] https://code.launchpad.net/~ltrager/maas/+git/maas/+merge/337909

See original description

Tags:

Related branches

~ya-bo-ng/maas:enable-fix-js-tests

Merged into maas:master

Blake Rouse (community): Approve on 2018-02-21

Lee Trager (ltrager) on 2018-02-17

Changed in maas:
milestone:	none → 2.4.0alpha2
description:	updated

Lee Trager (ltrager) on 2018-02-17

description:

updated

Revision history for this message

Blake Rouse (blake-rouse) wrote on 2018-02-20:

Disabling all tests in test_maas_obj_form.js is not good, not good at all. You do realize that all updating forms use that directive to update objects in MAAS over the websocket.

Revision history for this message

Andres Rodriguez (andreserl) wrote on 2018-02-20: Re: [Bug 1750092] Re: [2.4, UI] Reenable broken Javascript tests

@Blake,

Not all the tests are disabled. They were mistakenly by the commit
replacing the new vanilla.

Lee noticed that, renabled most of them, but some of there were more
complicated to fix so he filed the bug to track this.

On Tue, Feb 20, 2018 at 9:55 AM Blake Rouse <email address hidden>
wrote:

> Disabling all tests in test_maas_obj_form.js is not good, not good at
> all. You do realize that all updating forms use that directive to update
> objects in MAAS over the websocket.
>
> --
> You received this bug notification because you are subscribed to MAAS.
> https://bugs.launchpad.net/bugs/1750092
>
> Title:
> [2.4, UI] Reenable broken Javascript tests
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/maas/+bug/1750092/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: product=maas; milestone=2.4.0alpha2; status=Triaged;
> importance=Critical; assignee=None;
> Launchpad-Bug-Tags: vanilla-transition
> Launchpad-Bug-Information-Type: Public
> Launchpad-Bug-Private: no
> Launchpad-Bug-Security-Vulnerability: no
> Launchpad-Bug-Commenters: blake-rouse ltrager
> Launchpad-Bug-Reporter: Lee Trager (ltrager)
> Launchpad-Bug-Modifier: Blake Rouse (blake-rouse)
> Launchpad-Message-Rationale: Subscriber (MAAS)
> Launchpad-Message-For: andreserl
>
--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

Anthony Dillon (ya-bo-ng) on 2018-02-20

Changed in maas:
assignee:	nobody → Anthony Dillon (ya-bo-ng)
status:	Triaged → In Progress

MAAS Lander (maas-lander) on 2018-02-21

Changed in maas:
status:	In Progress → Fix Committed

Andres Rodriguez (andreserl) on 2018-03-13

Changed in maas:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.