MAAS

[2.4, UI] Logs tab is missing

Bug #1750015 reported by Lee Trager
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Anthony Dillon
MAAS 2.4.0alpha2

Bug Description

The logs tab on the machine and controller details page is missing. The logs tab contains the machine summary and installation output if available.

Related branches

~ya-bo-ng/maas:logs-tab
Andres Rodriguez (community): Approve
Lee Trager (community): Needs Information
Diff: 73 lines (+18/-23)
2 files modified
src/maasserver/static/js/angular/directives/call_to_action.js (+1/-1)
src/maasserver/static/partials/node-details.html (+17/-22)
Lee Trager (ltrager)
Changed in maas:
milestone: none → 2.4.0alpha2
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Lee, I don't think this is a regression. The logic has not changed at all.

2.3:
https://github.com/maas/maas/blob/2.3/src/maasserver/static/partials/node-details.html#L214

master:
https://github.com/maas/maas/blob/master/src/maasserver/static/partials/node-details.html#L284

Are you sure the machines have `machine_output.viewable` set to true?

Revision history for this message
Lee Trager (ltrager) wrote :

As part of the effort to improve UI performance I replaced machine_output with has_logs in December [1]. It seems at least the HTML has been reverted during the vanilla transition.

[1] https://github.com/maas/maas/commit/3d162802f0187ab4e98173fb6ac2a927e1bc23f3#diff-bd9a25d0c13510a6ce92a19bf8e47161R219

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Log tabs not showing the content.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Logs tab showing just a few lines of content at the bottom (not all that's on top or below)

Revision history for this message
Andres Rodriguez (andreserl) wrote :

The dropdown is completely misplaced.

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Oh I see, will fix the drop down first thing tomorrow.

Anthony Dillon (ya-bo-ng)
Changed in maas:
status: Triaged → In Progress
Revision history for this message
Andres Rodriguez (andreserl) wrote :

@Ant, will it be in the same branch ?

MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.