Virsh pod creation failed with "Node with hostname already exists."

There is already code in MAAS that checks for the validity and uniqueness of hostnames when a Pod is added. However, currently the check is against Machine's in the database and the reason Mike hit this bug is because his MAAS server had a hostname that matched one of his VMs.

IIRC, I thought we agreed we were gonna do a deterministic name scheme.
Thinking about it, we should auto create a name unless the user specifies
it to be sticky.

Thoughts?
On Thu, May 4, 2017 at 6:05 PM Newell Jensen <email address hidden>
wrote:

> There is already code in MAAS that checks for the validity and
> uniqueness of hostnames when a Pod is added. However, currently the
> check is against Machine's in the database and the reason Mike hit this
> bug is because his MAAS server had a hostname that matched one of his
> VMs.
>
> --
> You received this bug notification because you are subscribed to MAAS.
> https://bugs.launchpad.net/bugs/1687487
>
> Title:
> Virsh pod creation failed with "Node with hostname already exists."
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/maas/+bug/1687487/+subscriptions
>
--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

I like the way we have it now, if there is a conflict in validity or uniqueness with one of the Pod's machines, we create a random hostname. My branch fixes the issue that Mike ran into with his MAAS server hostname clashing with one of his VM's hostnames.

But then again, doing something deterministic, like appending something to the conflicting hostname could be done as well. That way, the Pod admin will most likely notice which machine is which without too much investigation. Since we use random hostnames in other places, that is more in line with what is currently done.