[2.2] MAAS does not correctly manage DNS for DHCP-provided hostnames
Bug #1686234 reported by
Mike Pontillo
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Mike Pontillo | ||
Bug Description
When a DHCP lease is created, MAAS uses the hostname provided by the DHCP client to create a DNS record.
This has several issues:
(1) Hostnames with invalid characters are allowed. For example, I saw a hostname like "Nintendo 3DS.maas" on my home MAAS.
(2) When the DHCP lease is released, the DNS record is not removed; it remains in the database with no IP addresses associated with it.
(3) When a DHCP lease is acquired, it can add a DNS record that clashes with the hostname of an existing node.
(4) A dynamic DHCP request can incorrectly affect an existing preconfigured static DNS entry.
Related branches
lp://staging/~mpontillo/maas/dns-dhcp-fixes--bug-1686234
- Blake Rouse (community): Approve
- Andres Rodriguez (community): Needs Information
-
Diff: 766 lines (+419/-69)11 files modifiedsrc/maasserver/models/dnsresource.py (+69/-0)
src/maasserver/models/signals/staticipaddress.py (+22/-4)
src/maasserver/models/signals/tests/test_staticipaddress.py (+5/-2)
src/maasserver/models/tests/test_dnsresource.py (+148/-3)
src/maasserver/rpc/leases.py (+39/-14)
src/maasserver/rpc/tests/test_leases.py (+84/-4)
src/maasserver/testing/factory.py (+11/-2)
src/provisioningserver/rpc/tests/test_utils.py (+0/-24)
src/provisioningserver/rpc/utils.py (+1/-16)
src/provisioningserver/utils/network.py (+16/-0)
src/provisioningserver/utils/tests/test_network.py (+24/-0)
| Changed in maas: | |
| assignee: | nobody → Mike Pontillo (mpontillo) |
| milestone: | 2.2.1 → 2.2.0rc3 |
| summary: |
- [2.2] MAAS does not delete DNS records for released DHCP leases + [2.2] MAAS does not correctly manage DNS for DHCP-provided hostnames |
| Changed in maas: | |
| status: | Triaged → In Progress |
| description: | updated |
| Changed in maas: | |
| milestone: | 2.2.0rc3 → 2.2.0rc4 |
| Changed in maas: | |
| importance: | Medium → High |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
