| 2016-07-18 19:30:00 |
Lee Trager |
bug |
|
|
added bug |
| 2016-07-18 19:32:36 |
Andres Rodriguez |
summary |
[2.0RC3] Unable to add a public SSH Key |
[2.0RC2] Unable to add a public SSH Key |
|
| 2016-07-18 19:56:33 |
Lee Trager |
description |
When I add a public SSH key over the API or in the UI I get the following error
$ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)"
{"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}
This was introduced in 5118 in the validation code of SSH keys. |
When I add a public SSH key over the API or in the UI I get the following error
$ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)"
{"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}
This was introduced in 5118 in the validation code of SSH keys but appears to be exposing a bigger bug. If you run ./bin/test.rack src/provisioningserver/utils/tests/test_sshkey.py the tests fail. I'm guessing that something is mocking check_output in a previous test and not unmocking it. |
|
| 2016-07-18 20:13:41 |
Chris Gregan |
tags |
|
cdo-qa-blocker |
|
| 2016-07-18 20:34:02 |
Andres Rodriguez |
bug task added |
|
python3.5 (Ubuntu) |
|
| 2016-07-18 20:34:32 |
Andres Rodriguez |
bug task deleted |
python3.5 (Ubuntu) |
|
|
| 2016-07-18 20:39:07 |
Gavin Panella |
maas: assignee |
|
Gavin Panella (allenap) |
|
| 2016-07-18 20:39:10 |
Gavin Panella |
maas: status |
Triaged |
In Progress |
|
| 2016-07-18 20:40:14 |
John George |
tags |
cdo-qa-blocker |
cdoqa-blocker |
|
| 2016-07-18 20:41:22 |
Launchpad Janitor |
branch linked |
|
lp:~ltrager/maas/lp1604128 |
|
| 2016-07-18 20:47:52 |
Launchpad Janitor |
branch linked |
|
lp:~allenap/maas/pathlib-regression--bug-1604128 |
|
| 2016-07-18 21:19:40 |
Andres Rodriguez |
summary |
[2.0RC2] Unable to add a public SSH Key |
[2.0RC2] Unable to add a public SSH Key due to lp1604147 |
|
| 2016-07-18 21:20:12 |
Andres Rodriguez |
nominated for series |
|
maas/2.0 |
|
| 2016-07-18 21:20:12 |
Andres Rodriguez |
bug task added |
|
maas/2.0 |
|
| 2016-07-18 21:20:12 |
Andres Rodriguez |
nominated for series |
|
maas/trunk |
|
| 2016-07-18 21:20:12 |
Andres Rodriguez |
bug task added |
|
maas/trunk |
|
| 2016-07-18 21:20:17 |
Andres Rodriguez |
maas/2.0: milestone |
|
2.0.0 |
|
| 2016-07-18 21:20:21 |
Andres Rodriguez |
maas/trunk: milestone |
2.0.0 |
2.1.0 |
|
| 2016-07-18 21:20:30 |
Andres Rodriguez |
maas/2.0: milestone |
2.0.0 |
2.1.0 |
|
| 2016-07-18 21:20:33 |
Andres Rodriguez |
maas/2.0: milestone |
2.1.0 |
2.0.0 |
|
| 2016-07-18 21:22:39 |
Andres Rodriguez |
bug task added |
|
maas (Ubuntu) |
|
| 2016-07-18 21:22:52 |
Andres Rodriguez |
nominated for series |
|
Ubuntu Yakkety |
|
| 2016-07-18 21:22:52 |
Andres Rodriguez |
bug task added |
|
maas (Ubuntu Yakkety) |
|
| 2016-07-18 21:22:52 |
Andres Rodriguez |
nominated for series |
|
Ubuntu Xenial |
|
| 2016-07-18 21:22:52 |
Andres Rodriguez |
bug task added |
|
maas (Ubuntu Xenial) |
|
| 2016-07-18 21:23:25 |
Andres Rodriguez |
maas (Ubuntu Xenial): importance |
Undecided |
Critical |
|
| 2016-07-18 21:23:33 |
Andres Rodriguez |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2016-07-18 21:26:41 |
Andres Rodriguez |
description |
When I add a public SSH key over the API or in the UI I get the following error
$ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)"
{"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}
This was introduced in 5118 in the validation code of SSH keys but appears to be exposing a bigger bug. If you run ./bin/test.rack src/provisioningserver/utils/tests/test_sshkey.py the tests fail. I'm guessing that something is mocking check_output in a previous test and not unmocking it. |
[Impact]
With a recent update of python from 3.5.1 to 3.5.2, the pathlib.Path.path property is gone. This impacts MAAS as it will case it to fail importing SSH keys, which prevents users from deploying.
[Test Case]
1. Intsall MAAS
2. Import SSH Key (example, maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)")
With fix - The key will be imported correctly.
Without fix - The key will fail to import.
Work around sudden loss of pathlib.Path.path property in Python 3.5.2 release.
[Regression Potential]
None. Tested and proved that using the different path fixes the issue.
== Original bug report ==
When I add a public SSH key over the API or in the UI I get the following error
$ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)"
{"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}
This was introduced in 5118 in the validation code of SSH keys but appears to be exposing a bigger bug. If you run ./bin/test.rack src/provisioningserver/utils/tests/test_sshkey.py the tests fail. I'm guessing that something is mocking check_output in a previous test and not unmocking it. |
|
| 2016-07-18 21:26:46 |
Andres Rodriguez |
maas (Ubuntu Yakkety): importance |
Undecided |
Critical |
|
| 2016-07-18 21:26:48 |
Andres Rodriguez |
maas/2.0: importance |
Undecided |
Critical |
|
| 2016-07-18 21:29:22 |
Steve Langasek |
description |
[Impact]
With a recent update of python from 3.5.1 to 3.5.2, the pathlib.Path.path property is gone. This impacts MAAS as it will case it to fail importing SSH keys, which prevents users from deploying.
[Test Case]
1. Intsall MAAS
2. Import SSH Key (example, maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)")
With fix - The key will be imported correctly.
Without fix - The key will fail to import.
Work around sudden loss of pathlib.Path.path property in Python 3.5.2 release.
[Regression Potential]
None. Tested and proved that using the different path fixes the issue.
== Original bug report ==
When I add a public SSH key over the API or in the UI I get the following error
$ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)"
{"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}
This was introduced in 5118 in the validation code of SSH keys but appears to be exposing a bigger bug. If you run ./bin/test.rack src/provisioningserver/utils/tests/test_sshkey.py the tests fail. I'm guessing that something is mocking check_output in a previous test and not unmocking it. |
[Impact]
With a recent update of python from 3.5.1 to 3.5.2, the pathlib.Path.path property is gone. This impacts MAAS as it will cause it to fail importing SSH keys, which prevents users from deploying.
[Test Case]
1. Install MAAS
2. Import SSH Key (example, maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)")
With fix - The key will be imported correctly.
Without fix - The key will fail to import.
Work around sudden loss of pathlib.Path.path property in Python 3.5.2 release.
[Regression Potential]
None. Tested and proved that using the different path fixes the issue.
== Original bug report ==
When I add a public SSH key over the API or in the UI I get the following error
$ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@canonical.com)"
{"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}
This was introduced in 5118 in the validation code of SSH keys but appears to be exposing a bigger bug. If you run ./bin/test.rack src/provisioningserver/utils/tests/test_sshkey.py the tests fail. I'm guessing that something is mocking check_output in a previous test and not unmocking it. |
|
| 2016-07-18 21:30:29 |
Steve Langasek |
maas (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2016-07-18 21:30:33 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2016-07-18 21:30:40 |
Steve Langasek |
tags |
cdoqa-blocker |
cdoqa-blocker verification-needed |
|
| 2016-07-18 22:34:29 |
Launchpad Janitor |
maas (Ubuntu Yakkety): status |
New |
Fix Released |
|
| 2016-07-18 22:50:39 |
Andres Rodriguez |
tags |
cdoqa-blocker verification-needed |
cdoqa-blocker verification-done |
|
| 2016-07-18 23:06:38 |
Launchpad Janitor |
maas (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2016-07-18 23:06:43 |
Steve Langasek |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2016-07-18 23:17:13 |
MAAS Lander |
maas/trunk: status |
In Progress |
Fix Committed |
|
| 2016-07-18 23:44:30 |
Launchpad Janitor |
branch linked |
|
lp:~ltrager/maas/lp1604128_2.0 |
|
| 2016-07-19 05:45:31 |
MAAS Lander |
maas/2.0: status |
New |
Fix Committed |
|
| 2016-07-22 05:08:43 |
Trent Lloyd |
maas (Ubuntu Xenial): status |
Fix Released |
Confirmed |
|
| 2016-07-22 14:14:42 |
james lee |
maas (Ubuntu Xenial): status |
Confirmed |
Fix Committed |
|
| 2016-07-22 14:14:46 |
james lee |
maas (Ubuntu Xenial): status |
Fix Committed |
Confirmed |
|
| 2016-07-25 15:55:17 |
Richard Gasiorowski |
maas (Ubuntu Xenial): milestone |
|
xenial-updates |
|
| 2016-08-05 14:03:09 |
John Lewis |
bug |
|
|
added subscriber John Lewis |
| 2016-08-05 14:05:01 |
Victor Tapia |
bug |
|
|
added subscriber Victor Tapia |
| 2016-08-09 14:09:22 |
Victor Tapia |
tags |
cdoqa-blocker verification-done |
cdoqa-blocker sts verification-done |
|
| 2016-08-11 15:23:16 |
Riccardo Magrini |
attachment added |
|
Screen Shot 2016-08-11 at 17.21.51.png https://bugs.launchpad.net/maas/+bug/1604128/+attachment/4719144/+files/Screen%20Shot%202016-08-11%20at%2017.21.51.png |
|
| 2016-08-15 20:21:15 |
Brandon B. Jozsa |
maas/2.0: status |
Fix Committed |
Fix Released |
|
| 2016-08-21 22:52:38 |
Alexander Gabert |
attachment added |
|
Screenshot from 2016-08-22 00:51:57.png https://bugs.launchpad.net/maas/+bug/1604128/+attachment/4725189/+files/Screenshot%20from%202016-08-22%2000%3A51%3A57.png |
|
| 2016-08-21 23:02:25 |
Alexander Gabert |
attachment added |
|
Screenshot from 2016-08-22 01:02:14.png https://bugs.launchpad.net/maas/+bug/1604128/+attachment/4725198/+files/Screenshot%20from%202016-08-22%2001%3A02%3A14.png |
|
| 2016-08-22 16:33:56 |
Andres Rodriguez |
maas: status |
Fix Committed |
Fix Released |
|
| 2016-08-22 16:36:30 |
Andres Rodriguez |
maas/trunk: milestone |
2.0.1 |
|
|
| 2016-08-25 09:21:40 |
Mariusz |
bug |
|
|
added subscriber Mariusz |
