When a power template fails, the content of the event from the node event log is not readable (it contains the whole template)
Bug #1357071 reported by
Raphaël Badin
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Julian Edwards | ||
Bug Description
The event log content is generated from /usr/lib/
"""
return "Command '%s' returned non-zero exit status %d" % (self.cmd, self.returncode)
"""
The result is that the entire template is present in the error message, and thus in the event log (see an example here: http://
Related branches
lp://staging/~julian-edwards/maas/fix-power-error-message
- Jeroen T. Vermeulen (community): Approve
-
Diff: 30 lines (+5/-4)2 files modifiedsrc/maasserver/models/tests/test_node.py (+3/-3)
src/provisioningserver/power/poweraction.py (+2/-1)
Revision history for this message
| Raphaël Badin (rvb) wrote | #1 |
| summary: |
When a power template fails, the content of the event from the node - event log is not very readable (it contains the whole template) + event log is not readable (it contains the whole template) |
Revision history for this message
| Blake Rouse (blake-rouse) wrote | #2 |
| Changed in maas: | |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Triaged |
| Changed in maas: | |
| assignee: | Blake Rouse (blake-rouse) → Julian Edwards (julian-edwards) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | none → 1.7.0 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
For a much better handle on what ends up in the node event log when a power-related action fails, we should move away from using shell templates and use Python instead. Note that this work has started: https:/