MAAS should not allow editing network interfaces of deployed machines

Bug #2032720 reported by Bui Hong Ha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Triaged
High
Unassigned
maas-ui
Triaged
Medium
Unassigned

Bug Description

Currently, MaaS does not allow network interfaces' configurations (for example: changing fabrics, changing subnet) to be modified after a machine was deployed. When a user try to modify the fabric in MaaS UI by Machine > Network > Actions > Edit Physical, MaaS UI allows users the form to be submitted but does not output any validation error.

It would be helpful if MaaS UI can display validation error when a user tries to change interfaces after machine deployment.

summary: - MaaS should show alert messages when network interfaces of deployed
+ MAAS should show alert messages when network interfaces of deployed
machines are modified
Revision history for this message
Thorsten Merten (thorsten-merten) wrote (last edit ):

Were able to reproduce it. We could also think about disabling the edit physical button for deployed machines instead of showing an error afterwards.

Changed in maas-ui:
importance: Undecided → Medium
milestone: none → 3.5.0
status: New → Triaged
summary: - MAAS should show alert messages when network interfaces of deployed
- machines are modified
+ MAAS should not allow editing network interfaces of deployed machines
Revision history for this message
Christian Grabowski (cgrabowski) wrote :

Confirmed on the backend as well, it seems the DeployedInterfaceForm inherits from MAASModelForm rather than InterfaceForm, which has a generic save and has no logic preventing edits, even more so than the regular InterfaceForm child classes.

Changed in maas:
status: New → Triaged
importance: Undecided → High
milestone: none → 3.5.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.