maas-ui

Adding a KVM pod over the UI doesn’t provide the option to skip commissioning pre-existing VMs

Bug #1696512 reported by Peter Sabaini
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
MAAS
Invalid
Medium
Unassigned
MAAS 3.4.0-rc1
maas-ui
Incomplete
Medium
Unassigned
maas-ui 3.4.x

Bug Description

UI enhancement: when configuring a virsh pod, maas immediately paves over existing KVMs without asking for confirmation. From a principle of least astonishment point of view maas should probably ask for confirmation before performing an operation that cannot be undone.

Version 2.2.0+bzr6054-0ubuntu1~16.04.1

Alvaro Uria (aluria)
tags: added: canonical-bootstack
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi Peter,

This has been done by design and it is exactly the same behavior as to when we added a 'Virsh' Chassis. Since the 'pods' concept is that MAAS will manage all available resources, MAAS will commissioning whatever has been pre-created to correctly gather information on it.

Changed in maas:
status: New → Won't Fix
milestone: none → 2.3.0
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.3.0 → none
Revision history for this message
Dean Henrichsmeyer (dean) wrote :

If that's by design, we should re-design it. It's poor UX. If you add a virsh POD that has existing KVMs it should error, not nuke data. At the very least there should be an exceptional confirmation where we warn them that there are existing KVMs and the data will be nuked.

Revision history for this message
Blake Rouse (blake-rouse) wrote :

No data will be nuked. We do not auto deploy the machines! The machine will just be commissioned to gather the VM's information.

Revision history for this message
Xav Paice (xavpaice) wrote :

So, commissioning a box does nothing at all to the disk on the machine? It does reboot the machine, which is far from ideal if you don't know that's going to happen.

From what I could tell testing yesterday, with a Maas 2.2.2 setup on Xenial, I added a pod using the virsh params for a machine which wasn't previously known to maas. There were two VMs already defined on that host, one for the maas service itself, and one named 'dhcp1'. Adding the pod left the maas VM alone (thankfully) and rebooted the dhcp1 VM into 'commissioning', after which it was left unable to boot normally. The VM has since been deleted and recreated, which means I am unable to tell the extent of what actually happened to it's disk image.

Dean Henrichsmeyer (dean)
Changed in maas:
status: Won't Fix → Confirmed
milestone: none → 2.6.0
Andres Rodriguez (andreserl)
summary: - [2.2] UI: adding a virsh pod immediately commissions existing kvms
+ [2.5, UI] Adding a KVM pod over the UI doesn’t provide the option to
+ skip commissioning
tags: added: ui ux
Andres Rodriguez (andreserl)
summary: - [2.5, UI] Adding a KVM pod over the UI doesn’t provide the option to
+ [2.5, UI, UX] Adding a KVM pod over the UI doesn’t provide the option to
skip commissioning
summary: [2.5, UI, UX] Adding a KVM pod over the UI doesn’t provide the option to
- skip commissioning
+ skip commissioning pre-existing VMs
Revision history for this message
Dean Henrichsmeyer (dean) wrote : Re: [2.5, UI, UX] Adding a KVM pod over the UI doesn’t provide the option to skip commissioning pre-existing VMs

Whether it nukes data or not, MAAS is taking something down that it did not create as a side effect of another action. At the very least there should be a confirmation required from the user acknowledging that it's going to happen and/or a way to opt-out of the commissioning of existing VMs.

Lilyana Videnova (lilyanavidenova)
Changed in maas:
importance: Undecided → Medium
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.6.0 → 2.6.0beta2
summary: - [2.5, UI, UX] Adding a KVM pod over the UI doesn’t provide the option to
- skip commissioning pre-existing VMs
+ [2.5, UI, UX, pod] Adding a KVM pod over the UI doesn’t provide the
+ option to skip commissioning pre-existing VMs
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.6.0beta2 → 2.6.0rc1
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.6.0rc1 → 2.6.0rc2
Andres Rodriguez (andreserl)
Changed in maas:
milestone: 2.6.0rc2 → 2.7.0alpha1
Adam Collard (adam-collard)
Changed in maas:
milestone: 2.7.0b1 → 2.7.0b2
Adam Collard (adam-collard)
Changed in maas:
milestone: 2.7.0b2 → none
Revision history for this message
Chris Sanders (chris.sanders) wrote : Re: [2.5, UI, UX, pod] Adding a KVM pod over the UI doesn’t provide the option to skip commissioning pre-existing VMs

Was this bug removed from development as the last update seems to imply?

Björn Tillenius (bjornt)
Changed in maas:
status: Confirmed → Triaged
Bug Watch Updater (bug-watch-updater)
Changed in maas-ui:
importance: Undecided → Unknown
Adam Collard (adam-collard)
summary: - [2.5, UI, UX, pod] Adding a KVM pod over the UI doesn’t provide the
- option to skip commissioning pre-existing VMs
+ Adding a KVM pod over the UI doesn’t provide the option to skip
+ commissioning pre-existing VMs
Changed in maas:
milestone: none → 3.4.0
Revision history for this message
Thorsten Merten (thorsten-merten) wrote :

imported from https://github.com/canonical/maas-ui/issues/1526

Changed in maas-ui:
status: New → Triaged
importance: Unknown → Medium
milestone: none → 3.4.0
Revision history for this message
Thorsten Merten (thorsten-merten) wrote :

If this has been fixed for LXD, should we still aim to fix it for virsh as it will be deprecated anyways?

Changed in maas:
status: Triaged → Invalid
Revision history for this message
Thorsten Merten (thorsten-merten) wrote :

setting to invalid for MAAS as this can be done in maas-ui

Revision history for this message
Thorsten Merten (thorsten-merten) wrote :

is this still an issue in current MAAS and especially also with LXD?

Changed in maas-ui:
milestone: 3.4.0 → 3.4.x
status: Triaged → Incomplete
tags: removed: ui
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.