NoSuchId: The file id "etc-20101119044251-5jfdakonern1nd08-2" is not present in the tree <bzrlib.inventory.CHKInventory object at 0x2ae2a55c7990>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/3/2011 5:14 AM, Robert Collins wrote:
> http://bazaar.launchpad.net/%7Edaker/dexter-
> rolodex/fix.688511/view/24.1.5/data/media/background.png?sort=filename&remember=1&file_id=etc-20101119044251-5jfdakonern1nd08-2&compare_revid=1

Going here:
http://bazaar.launchpad.net/~daker/dexter-rolodex/fix.688511/view/24.1.5/data/media/background.png

Shows that it is a binary file.

I think the issue is that "compare_revid" is confusing us.

Going here:
http://bazaar.launchpad.net/~daker/dexter-rolodex/fix.688511/view/1/data/media/background.png

seems to also say that it is a binary file. But given the
'compare_revid', it looks like it wants the '1' to be a revision id, not
a revno.

Though expanding the 1 to the actual revision_id still gives an oops:
OOPS-1888CBB49

The fact that it is also passing 'etc-...' as the file_id while also
having media/background.png seems pretty confusing.

It certainly looks like someone hand-crafted that url. Regardless, we
shouldn't be OOPSing.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1vV+gACgkQJdeBCYSNAANF6ACdG6pgJspVFNjmihQiR32uIboy
64MAoIASGq9vpjdDGmLffxFFaqdv0P5y
=oFvF
-----END PGP SIGNATURE-----

Similar but not quite the same code path: OOPS-1904CBA26 and OOPS-1904CBA24

In the cases of "file_id None not in" the failure is because the path doesn't actual exist, and neither does its parent. We should just give a 404 or equivalent in that case.

I don't think that is the same bug as this, which is where we *have* a file_id, but it isn't found. Checking, though.

The original bug report is probably about someone asking to diff a file (in this case a binary file) against a revision where it wasn't present (at least, that is the hint I get from looking at the URL).
What confuses me about the original URL:
 http://bazaar.launchpad.net/~daker/dexter-rolodex/fix.688511/view/24.1.5/data/media/background.png?sort=filename&remember=1&file_id=etc-20101119044251-5jfdakonern1nd08-2&compare_revid=1

If I understand correctly, that is someone asking to find the changes for 'background.png' relative to 'etc'. Which is a directory which is completely unrelated. /data/media/background.png does exist in 24.1.5, but why would file_id=etc... be present?

Certainly smells of URL hacking causing us to OOPS.

ViewUI and AnnotateUI are fixed, but DiffUI, DownloadUI and possibly others are still broken.