loggerhead

loggerhead.history._process_diff should not exist

Bug #297953 reported by Robert Collins
2
Affects Status Importance Assigned to Milestone
loggerhead
Triaged
Low
Unassigned
loggerhead-breezy
Triaged
Low
Unassigned

Bug Description

About 30% of showing a diff in loggerhead with split inventory, is in
loggerhead.history._process_diff, which parses a plain text diff emitted
by bzrlib.

This is more than slightly nutty: we can output the diff in the
appropriate format in the first place rather than post-processing.

-Rob

 affects loggerhead
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Robert Collins (lifeless) wrote :

Turns out most of the time is in bzr grabbing the diffs; all the same, this is a bit fugly layer wise.

Martin Albisetti (beuno)
Changed in loggerhead:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Martin Albisetti (beuno) wrote :

bumping down to low since it's not actually a performance problem

Changed in loggerhead:
importance: High → Low
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oh yes, it's certainly ugly :)

I guess it involves cribbing code from bzrlib/patiencediff/unified_diff.py and rearranging as needed.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 297953] Re: loggerhead.history._process_diff should not exist

On Tue, 2008-12-23 at 19:44 +0000, Martin Albisetti wrote:
> bumping down to low since it's not actually a performance problem
>
> ** Changed in: loggerhead
> Importance: High => Low

30% of diff time isn't a performance issue ?

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Are you taking this comment: "Turns out most of the time is in bzr grabbing the diffs; all the same, this is a bit fugly layer wise." back?

Revision history for this message
Robert Collins (lifeless) wrote :

On Wed, 2009-02-25 at 18:46 +0000, Michael Hudson wrote:
> Are you taking this comment: "Turns out most of the time is in bzr
> grabbing the diffs; all the same, this is a bit fugly layer wise." back?

No, just going blind in my old age.

-Rob

Jelmer Vernooij (jelmer)
Changed in loggerhead-breezy:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.