team search not working
Bug #613132 reported by
Michael Hall
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| LoCo Team Portal |
Fix Released
|
Critical
|
Michael Hall | ||
Bug Description
After the new per-continent listing change, searching for a team doesn't work, it'll always show the entire list of teams.
Related branches
lp://staging/~mhall119/loco-team-portal/site-search
- Daniel Holbach (community): Approve
-
Diff: 742 lines (+153/-132)41 files modifiedloco_directory/common/context_processors.py (+5/-0)
loco_directory/common/forms.py (+11/-0)
loco_directory/common/views.py (+58/-0)
loco_directory/events/forms.py (+0/-10)
loco_directory/events/views.py (+0/-8)
loco_directory/settings.py (+1/-0)
loco_directory/teams/forms.py (+0/-9)
loco_directory/teams/views.py (+0/-7)
loco_directory/templates/about.html (+0/-2)
loco_directory/templates/about_loco.html (+0/-2)
loco_directory/templates/base.html (+7/-0)
loco_directory/templates/events/event_list.html (+0/-7)
loco_directory/templates/events/global_event_delete_confirm.html (+0/-3)
loco_directory/templates/events/global_event_detail.html (+0/-3)
loco_directory/templates/events/global_event_new.html (+0/-3)
loco_directory/templates/events/global_event_update.html (+0/-3)
loco_directory/templates/events/team_event_comment_new.html (+0/-3)
loco_directory/templates/events/team_event_delete_confirm.html (+0/-3)
loco_directory/templates/events/team_event_detail.html (+0/-3)
loco_directory/templates/events/team_event_new.html (+0/-3)
loco_directory/templates/events/team_event_new_select.html (+0/-3)
loco_directory/templates/events/team_event_register.html (+0/-3)
loco_directory/templates/events/team_event_update.html (+0/-3)
loco_directory/templates/index.html (+0/-2)
loco_directory/templates/irc_chat.html (+0/-2)
loco_directory/templates/loco_council.html (+0/-2)
loco_directory/templates/site_search.html (+67/-0)
loco_directory/templates/teams/merge_teams.html (+0/-1)
loco_directory/templates/teams/select_other_team.html (+0/-1)
loco_directory/templates/teams/team_detail.html (+0/-1)
loco_directory/templates/teams/team_event_history.html (+0/-2)
loco_directory/templates/teams/team_event_list.html (+0/-1)
loco_directory/templates/teams/team_list.html (+0/-7)
loco_directory/templates/teams/team_reapprovals.html (+0/-1)
loco_directory/templates/using_locodir.html (+0/-2)
loco_directory/templates/venues/venue_detail.html (+0/-3)
loco_directory/templates/venues/venue_list.html (+0/-7)
loco_directory/templates/venues/venue_update.html (+0/-3)
loco_directory/urls.py (+1/-0)
loco_directory/venues/forms.py (+0/-9)
loco_directory/venues/views.py (+3/-10)
| Changed in loco-directory: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: teams |
Revision history for this message
| YoBoY (yoboy-leguesh) wrote | #1 |
| Changed in loco-directory: | |
| importance: | High → Critical |
| Changed in loco-directory: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Michael Hall (mhall119) |
| Changed in loco-directory: | |
| milestone: | none → 0.2.21 |
| status: | In Progress → Fix Committed |
| Changed in loco-directory: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't have the skills to correct that bug, but the problem is in teams/views.py and in the team_list.html template.
We are doing our query on the global team_list and pass this to the template, but in the template we don't use it. Instead we use our new continent.
We have to use this team_list to have the search working or filter the other lists before passing them to the template.