Repeated password dialogs if dialog open while reconnecting

Bug #473998 reported by Olorin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LinuxDC++
Confirmed
Low
Unassigned

Bug Description

There shows a pwd request window if it needed. But It accumulates. 10, 20, 30.... 100 pwd windows stores in the memory and then shows one by one. Then on some of that windows all interface freezes and program gives no responce.
Confurmation is strongly needed for this bug. I don't know, why LDC does... no any ideas.

Olorin (vivliofika)
tags: added: password popup pwd
Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

screenshot please and steps to reproduce.

Changed in linuxdcpp:
status: New → Incomplete
Revision history for this message
Olorin (vivliofika) wrote :

no screens needed... I see only one request a time. GUI dialog as usual.

1) start the LDCPP
2) leave it
3) a hub request the password, don't enter it, just leave
4) the hub drops, reconnects and requests the password again and again
5) then try to input the password

Revision history for this message
Razzloss (razzloss) wrote :

Seems to happen as described.

Hub::getPassword_gui() blocks as long as either OK or Cancel is clicked. If hub disconnects the user during this function and client reconnects another getPassword_gui call is added to the gui queue. This loop continues until user is there to acknowledge (all) the dialog.

getPassword_gui should be changed so that it doesn't use gtk_dialog_run and if the hub disconnects while the dialog is visible it should be hidden. Also hub name should be added to the password dialog since with not using gtk_dialog_run it will be possible that multiple password prompts are open at one time from different hubs. (It might be a bit difficult identify the hub asking for password even with current implementation if there's more than 1 hub open).

Patches are welcome...

--RZ

Changed in linuxdcpp:
importance: Undecided → Low
status: Incomplete → Confirmed
Razzloss (razzloss)
summary: - got a problem om pwd request
+ Repeated password dialogs if dialog open while reconnecting
tags: added: hub
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.