LinuxDC++

TLS port should not be allowed to be the same as regular ports

Bug #363092 reported by Björn Pettersson on 2009-04-17

This bug affects 1 person

	Status	Importance	Assigned to
AirDC++	Fix Released	Medium	Unassigned
DC++	Fix Released	Low	Unassigned
LinuxDC++	Confirmed	Low	Unassigned

Bug Description

Using bzr release from yesterday.

Starting linuxdcpp I got a message saying the TLS port was busy and that I should change the TLS port in settings or close whatever application currently using that port.

I had set the TLS port to be the same as the regular TCP and UDP ports.This was what I did wrong.

It isn't obvious that it doesn't work with this setup, and even if it were obvious, I should not be allowed to set the TLS port to be the same as any of the other two ports. (Or, if TLS only uses TCP, the TLS port should not be allowed to be the same as the regular TCP port.)

See original description

Tags:

Björn Pettersson (bjorn-hygiena) on 2009-04-17

description:

updated

Revision history for this message

MikeJJ (mrmikejj) wrote on 2009-04-17:

For your info, It's just TCP. :)

Revision history for this message

Razzloss (razzloss) wrote on 2009-04-18:

Yeah, any volunteers to rewrite settingsdialog to report errors properly?

--RZ

Changed in linuxdcpp:
importance:	Undecided → Low
status:	New → Confirmed

eMTee (realprogger) on 2010-10-12

Changed in dcplusplus:
status:	New → Confirmed
importance:	Undecided → Low

Fredrik Ullner (ullner) on 2013-11-30

tags:

added: core

Fredrik Ullner (ullner) on 2013-11-30

tags:

added: win32-ui

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-11-30:

dcpp_tlsport.diff Edit (595 bytes, text/plain)

This patch will report an error when it's the same and not set up the secure server... This is an untested patch, so I'd appreciate if someone could verify its functionality.

Note that I did not change the UI, so the user will only get an error when starting DC++ or setting the TCP/TLS ports.

Revision history for this message

poy (poy) wrote on 2013-12-01:

not tested either but the code looks fine.

i would also add a check when changing settings to disallow setting the same ports in the first place.

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-12-01:

dcpp_tlsport.diff Edit (4.2 KiB, text/plain)

This patch will add popups when the user tries to set invalid values.

Also, it will write an empty string if the value is the same as as another port.

Changed in dcplusplus:
status:	Confirmed → In Progress

Revision history for this message

poy (poy) wrote on 2013-12-01:

good, but there are a couple of details to fix:

1) the search port doesn't need validation; it can be (and often is) the same as another port (works as one is TCP, the other UDP).

2) i18n macros: change "_T" to "T_" and "Text::toT(str(F_(" to "str(TF_(".

maksis (maksis) on 2013-12-02

Changed in airdcpp:
status:	New → Confirmed
importance:	Undecided → Medium

Revision history for this message

Fredrik Ullner (ullner) wrote on 2013-12-09:

dcpp_tlsport.diff Edit (3.4 KiB, text/plain)

The attached patch fixes the mentioned two items.

On 1), I initially did not do it with the search box, but then I saw the following in the help for the TLS box: "Note that this port value should be different than the ones used for transfers (TCP) and searches (UDP)."

Revision history for this message

poy (poy) wrote on 2013-12-09:

looking good... feel free to correct help inaccuracies as well.

Fredrik Ullner (ullner) on 2013-12-09

Changed in dcplusplus:
status:	In Progress → Fix Committed

Revision history for this message

iceman50 (bdcdevel) wrote on 2013-12-10:

Shouldn't validatePort be changed as taking the TextBoxPtr's are pointless?

Revision history for this message

poy (poy) wrote on 2014-03-31:

#10

Fixed in DC++ 0.840.

Changed in dcplusplus:
status:	Fix Committed → Fix Released

Revision history for this message

Sopor (sopor) wrote on 2017-08-07:

#11

This would be nice if this could be fixed in AirDC++ too. Too many users are mixing this up and write the same port number in TLS as they use in TCP...

Sopor (sopor) on 2020-02-20

Changed in airdcpp:
status:	Confirmed → Fix Committed

Sopor (sopor) on 2020-10-20

Changed in airdcpp:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.