Number of users is incorrectly calculated on ADC hub

Bug #271708 reported by E_zombie
2
Affects Status Importance Assigned to Milestone
LinuxDC++
Fix Released
Medium
Razzloss

Bug Description

I use linuxdcpp on ADC hub (https://launchpad.net/dshub)
after 10-20 hours uptime count users on linuxdcpp != [command] !stats on ADC hub != apex based DC clent (see screenshot).

bug Linuxdcpp ?

maybe it linking whit used !rename command on adc hub or some bug ADC DShub ?

Tags: adc hub ui
Revision history for this message
E_zombie (lv77) wrote :
description: updated
Revision history for this message
Razzloss (razzloss) wrote :

I assume 0.705 that branch is used? (Though it shouldn't matter)

If I understood correctly !rename changes the nick of a user while he is logged in? If this is the case the old nick should stay in the userlist and the new one is added when changing nick. This is because of a bug in Hub::findUser_gui/updateUser_gui, which incorrectly uses Nick instead of CID to identify user updates.

Can you confirm that the both nicks are found in the userlist after rename?

--RZ

Revision history for this message
E_zombie (lv77) wrote :

yes.

i try to !kick this users and press <tab> and nick autocomplited, but server say "user not connected"

Revision history for this message
E_zombie (lv77) wrote :

after use !rename

Razzloss (razzloss)
Changed in linuxdcpp:
assignee: nobody → razzloss
status: New → In Progress
Revision history for this message
Razzloss (razzloss) wrote :

OK - rev. 27 should fix this. Please update, compile and confirm here. As I haven't really tested this one (too lazy to find/install ADC hub)...

Steven: I'm attaching this patch incase you want to apply it to stable branch also (it should also be affected). It won't apply cleanly, but meh..
--RZ

Changed in linuxdcpp:
status: In Progress → Fix Committed
Revision history for this message
Razzloss (razzloss) wrote :

E_zombie: Have you tried a revision with a fix yet? And what was the result?

--RZ

Revision history for this message
E_zombie (lv77) wrote :

bug not fixed.

user whit new nic add to user list , but old nick not removed

Razzloss (razzloss)
Changed in linuxdcpp:
status: Fix Committed → Confirmed
Revision history for this message
E_zombie (lv77) wrote :

- adc://adc.san.ru:10000
- adc://adc2.san.ru:10000
- adc://adc3.san.ru:10000
- adc://adc.volsk.san.ru:1411

Revision history for this message
Razzloss (razzloss) wrote :

Seems to work ok for me.

--RZ

Changed in linuxdcpp:
status: Confirmed → Fix Committed
Razzloss (razzloss)
Changed in linuxdcpp:
importance: Undecided → Medium
Changed in linuxdcpp:
status: Fix Committed → Fix Released
Razzloss (razzloss)
Changed in linuxdcpp:
status: Fix Released → Fix Committed
Changed in linuxdcpp:
milestone: none → 1.1.0
tags: added: hub ui
tags: added: adc
Changed in linuxdcpp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.