Linaro Android

  1. Bug #1023985
  2. Comment #1

Comment 1 for bug 1023985

Revision history for this message
Zach Pfeffer (pfefferz) wrote : Re: Surfaceflinger times out on early suspend poll causing wasted compute

Thread:

John Stultz ✆
15:01 (20 hours ago)

to me, Deepak, Jon, Thomas, Amit, Annamalai, rosenkranzer, Kejun, Patrik, Vishal, yong, Zygmunt
On 07/11/2012 12:46 PM, Zach Pfeffer wrote:
On 11 July 2012 14:45, John Stultz <email address hidden> wrote:
On 07/11/2012 12:40 PM, Deepak Saxena wrote:
On 11 July 2012 12:37, Zach Pfeffer <email address hidden> wrote:
Deepak/John

What userspace changes are you looking for?
Basically we want to remove the polling calls from userspace into the
earlysuspend APIs. This is the best long-term solution and we could
maybe just give it the code to Google to integrate into the next
release.
Well, that might be optimistic, as I suspect they already have something in
place.

But basically while I'm working on the kernel shim side, it may be good to
work this from both ends.
What device does it poll?

Looking at Tixy's change to remove the warning messages:
http://review.android.git.linaro.org/#change,1745

See boolDisplayHardwareBase::DisplayEventThread::threadLoop()

http://source-android.frandroid.com/frameworks/base/services/surfaceflinger/DisplayHardware/DisplayHardwareBase.cpp

I'm guessing if we modified Tixy's change to not just return but to sleep for 10 seconds before doing so, it likely will provide similar behavior to what I'm planning.