Linaro Android Bot Review

Get rid of last print's in bot code

Bug #884390 reported by Paul Sokolovsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Android Bot Review
Fix Released
Medium
Frans Gifford
Linaro Android Bot Review 11.11

Bug Description

Bot runs in an unattended mode as a cronjob, so it shouldn't really print anything to stdout, everything should go to logs (to stderr so far). It still print's some stuff, and that causes mail spam on the system it is deployed on.

Related branches

lp://staging/~fgiff/linaro-android-bot-review/884390
Paul Sokolovsky: Approve
Diff: 128 lines (+21/-21)
3 files modified
gerritconnection.py (+10/-10)
jenkinsconnection.py (+5/-5)
lavaconnection.py (+6/-6)
Revision history for this message
Frans Gifford (fgiff) wrote :

Still uses 'print' a lot. We'll remove these. Details below:

$ grep "print" *.py
androidbotreview.py: print i.get_lava_data(args.rest[0])
androidbotreview.py: print "Error: Not sure what you're trying to do. Rerun with -h for usage."
gerritconnection.py: print "Error: Failed to load known_hosts file so unable to \
gerritconnection.py: print "Error: Failed verification of gerrit's SSH key. \
gerritconnection.py: print "Error: Failed authentication to gerrit server. Please \
gerritconnection.py: print "Error: Failed to complete SSH session with gerrit."
gerritconnection.py: print "Error: Socket error when connecting to gerrit."
gerritconnection.py: print "Error: Failed to complete SSH session with gerrit \
gerritconnection.py: print "get_starred_list:", c.get_starred_list()
gerritconnection.py: print "get_reviewed_list:", c.get_reviewed_list()
jenkinsconnection.py: print "Error: could not open %s." % (jenkins_passwd_file)
jenkinsconnection.py: print "Error: failed to start build."
jenkinsconnection.py: print "Build url: %s" % (build_url)
jenkinsconnection.py: print "Failed to queue build: %s gave HTTP code %s." % (
jenkinsconnection.py: print c.get_job_list()
lavaconnection.py: print "Error: Couldn't get test results from LAVA."
lavaconnection.py: print "Error: Couldn't connect to LAVA."
lavaconnection.py: print "Error: Couldn't fetch test results for %s" % (
lavaconnection.py: print "Error: Couldn't connect to LAVA."

Changed in linaro-android-bot-review:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Frans Gifford (fgiff)
milestone: none → 11.11
Frans Gifford (fgiff)
Changed in linaro-android-bot-review:
status: Triaged → In Progress
Frans Gifford (fgiff)
Changed in linaro-android-bot-review:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.