handle interruped read and write calls
Bug #1648637 reported by
Alberts Muktupāvels
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Light Display Manager |
Fix Released
|
High
|
Unassigned | ||
| 1.10 |
Fix Committed
|
High
|
Unassigned | ||
| 1.18 |
Fix Committed
|
High
|
Unassigned | ||
| 1.2 |
Fix Committed
|
High
|
Unassigned | ||
| 1.20 |
Fix Committed
|
High
|
Unassigned | ||
| lightdm (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Precise |
Won't Fix
|
Undecided
|
Unassigned | ||
| Trusty |
New
|
Undecided
|
Unassigned | ||
| Xenial |
New
|
Undecided
|
Unassigned | ||
| Yakkety |
New
|
Undecided
|
Unassigned | ||
| Zesty |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Use SA_RESTART flag to make sure that interrupted calls to read and/or write are restarted.
In my case read is interrupted when reading login1_session_id. Result of not handling EINTR error is that login1_session_id is set to NULL and console_kit_cookie gets login1 session id.
Related warnings in lightdm.log:
[+0.44s] WARNING: Session pid=617: Error reading from session: Interrupted system call
[+0.70s] DEBUG: Activating VT 7
[+0.70s] DEBUG: Activating ConsoleKit session c1
[+0.70s] WARNING: Error getting ConsoleKit session: GDBus.Error:
And because login1_session_id is null fix for 1637758 bug does not work.
Related branches
lp://staging/~muktupavels/lightdm/retry-interrupted-read
- LightDM Development Team: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/process.c (+1/-1)
| Changed in lightdm: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| description: | updated |
| Changed in lightdm: | |
| status: | Triaged → Fix Committed |
| Changed in lightdm: | |
| milestone: | none → 1.21.2 |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in lightdm (Ubuntu Zesty): | |
| status: | New → Fix Released |
Revision history for this message
| Steve Langasek (vorlon) wrote | #2 |
| Changed in lightdm (Ubuntu Precise): | |
| status: | New → Won't Fix |
To post a comment you must log in.
This bug was fixed in the package lightdm - 1.21.3-0ubuntu1
---------------
lightdm (1.21.3-0ubuntu1) zesty; urgency=medium
* New upstream release:
- Fix crashes introduced in 1.21.2 due to environment variable changes
- Fix incorrect unref in XDMCP server code
- Fix logging warning
-- Robert Ancell <email address hidden> Fri, 09 Dec 2016 14:04:49 +1300