Export autologin-session to greeter

Bug #1707187 reported by Roland Tapken
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Light Display Manager
Fix Committed
Wishlist
Unassigned
1.18
Fix Committed
Wishlist
Unassigned
1.22
Fix Committed
Wishlist
Unassigned
1.24
Fix Committed
Wishlist
Unassigned

Bug Description

This is a complementary bug report to https://bugs.launchpad.net/lightdm-gtk-greeter/+bug/1707186, since the fix of this bug requires patching both, lightdm and lighthdm-gtk-greater.

Imported description from the other report:

When lightdm is configured with with 'autologin-user-timeout' > 0
any configured 'autologin-session' will be ignored and the autologin-user
will be logged in with the last used session instead (read from
/var/lib/lightdm/.cache/lightdm-gtk-greeter/state).

Example 1:

    autologin-user=foo
    autologin-user-timeout=0
    autologin-session=fluxbox

This works as intended, as the autologin is handled directly by 'lightdm'.

Example 2:

    autologin-user=foo
    autologin-user-timeout=10
    autologin-session=fluxbox

Now the autologin must be handled by the greeter, and this results
into starting the (last) selected session, which must not be the
same as the configured 'autologin-session'.

The fix is to explicitly set the session before doing the autologin.
But since the greeter hints doesn't give us any information about the
'autologin-session' a second patch to lightdm is also required).
However, since the attached patch to lightdm-gtk-greeter will just
keep the current behaviour if the second patch hasn't been applied
to lightdm it would be save to merge this anytime.

Revision history for this message
Roland Tapken (cybso) wrote :
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Can you convert this to a merge proposal?

Changed in lightdm:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I committed this with the associated changes to liblightdm and tests.

Changed in lightdm:
status: Triaged → Fix Committed
Revision history for this message
Robert Ancell (robert-ancell) wrote :

This has exposed a bug in LightDM - if the greeter does an automatic login without a session set it should use autologin-session (bug 1718565). This may actually solve your original issue.

Revision history for this message
Roland Tapken (cybso) wrote :

Hallo Robert, thanks for merging the fix. Regarding your question in #4 I think the complementary patch in the greeter is still required, since at least the GTK greeter actually *does* select a session on autologin - the default session or the one that has been selected on the last login.

Furthermore, as I've already noted in the lightdm-gtk-greeter's report, this might even be a security problem if this feature is used on kiosk systems where the autologin account should be bound to a very restrictive session (e.g. a custom session script where not desktop environment but only the kiosk application is started).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.