libvterm

osc_selection does not support clearing the selection

Bug #2029450 reported by Marcus Tillmanns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvterm
Fix Released
Undecided
Unassigned

Bug Description

From https://invisible-island.net/xterm/ctlseqs/ctlseqs.html:

"If the second parameter is neither a base64 string nor ? ,
then the selection is cleared."

See attached patch.

Revision history for this message
Marcus Tillmanns (marcusti) wrote :
Revision history for this message
Paul "LeoNerd" Evans (leonerd) wrote :

LGTM

Revision history for this message
Paul "LeoNerd" Evans (leonerd) wrote :

Actually on further testing, it doesn't actually clear on that condition. It only clears if the parameter is actually empty. It needs more work to handle the non-base64 case.

Revision history for this message
Paul "LeoNerd" Evans (leonerd) wrote :

Now partly resolved by the latest two commits, at least for when the parameter is empty.

833: Paul "LeoNerd" Evans 2023-08-03 Correctly handle empty chunks while dealing with selection
832: Paul "LeoNerd" Evans 2023-08-03 OSC 52 should clear the selection if the second parameter is empty (LP2029450)

Further work still needed to handle the non-base64 case. That'll need to be done within the main processing while() loop.

Paul "LeoNerd" Evans (leonerd)
Changed in libvterm:
status: New → In Progress
Revision history for this message
Paul "LeoNerd" Evans (leonerd) wrote :

Done

837: Paul "LeoNerd" Evans 2023-08-03 Abort a selection-set request on invalid Base64 data and ignore until ST (LP2029450)

Changed in libvterm:
status: In Progress → Fix Committed
Revision history for this message
Paul "LeoNerd" Evans (leonerd) wrote :

Fixed in v0.3.3

Changed in libvterm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.