Store URLs not escaped properly when logging in
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
libubuntuone | Status tracked in Trunk | |||||
Stable-0-10 |
New
|
Undecided
|
Unassigned | |||
Stable-0-12 |
New
|
Undecided
|
Unassigned | |||
Stable-0-4 |
New
|
Undecided
|
Unassigned | |||
Stable-3-0 |
Fix Released
|
High
|
John Lenton | |||
Trunk |
Fix Released
|
High
|
John Lenton | |||
libubuntuone (Ubuntu) |
Fix Released
|
High
|
Unassigned | |||
Oneiric |
Fix Released
|
High
|
Unassigned |
Bug Description
u1_music_
{
gchar *real_url, *oauth_
g_return_if_fail (U1_IS_MUSIC_STORE (music_store));
g_return_if_fail (url != NULL);
/* If the load_real_store callback is set up, disable it first */
if (music_
g_source_remove (music_
music_
}
real_url = g_strdup_printf ("%s%s?
url);
This isn't escaping the forward_on_to_url. What this means is this:
music_store-
U1_STORE_URL = /music/login
url = http://
will give the URL
https:/
which is wrong, because the parameter q2=b is a parameter of the one.ubuntu.com URL, not of the 7dserver URL. The forward_on_to_url needs to be escaped to http%3A/
To replicate:
1. Run Banshee
2. xdg-open 'u1ms:/
3. See a "My Music" green non-U1 store error page
What should happen:
3. See an Ubuntu One Music album page (if in the WORLD store territory) or an Ubuntu One Music error page (if not)
Related branches
- dobey (community): Approve
- Stuart Langridge (community): Approve
-
Diff: 26 lines (+4/-2)1 file modifiedlibubuntuone/u1-music-store.c (+4/-2)
description: | updated |
description: | updated |
tags: | added: u1-maverick-sru u1-natty-sru |
description: | updated |
Changed in libubuntuone (Ubuntu Oneiric): | |
status: | Confirmed → Fix Committed |
importance: | Undecided → High |
no longer affects: | libubuntuone (Ubuntu Maverick) |
no longer affects: | libubuntuone (Ubuntu Natty) |
Status changed to 'Confirmed' because the bug affects multiple users.