IndicateIndicator's leaks strings when indicators are added, removed, modified

Bug #1028184 reported by Charles Kerr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libindicate
Fix Released
Medium
Charles Kerr

Bug Description

The issue is in the g_variant_get() calls in libindicate/listener.c's proxy_signal_cb() call. The "IndicatorAdded", "IndicatorRemoved", and "IndicatorModified" handlers all pull type or property strings with g_variant_get(variant,"s",&str) but don't free the strings.

We don't hold onto any of these pointers long-term, so we'd be better off using g_variant_get(variant,"&s",&const_str) instead.

Related branches

Charles Kerr (charlesk)
Changed in libindicate:
assignee: nobody → Charles Kerr (charlesk)
status: New → In Progress
importance: Undecided → Medium
Charles Kerr (charlesk)
Changed in libindicate:
status: In Progress → Fix Committed
Changed in libindicate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.