DBus Menu

memory leak in label_notify_cb

Bug #785828 reported by JKL
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
DBus Menu
Fix Released
Undecided
Unassigned
DBus Menu 0.4.90
0.4
Fix Released
Undecided
Unassigned
DBus Menu 0.4.5
0.5
Fix Released
Undecided
Unassigned
DBus Menu 0.4.90
libdbusmenu (Ubuntu)
Fix Released
Undecided
Unassigned
Natty
Fix Released
Undecided
Unassigned
Oneiric
Fix Released
Undecided
Unassigned

Bug Description

http://bazaar.launchpad.net/~dbusmenu-team/dbusmenu/trunk/view/head:/libdbusmenu-gtk/parser.c

Line 830:

g_object_get_property (G_OBJECT (widget), pspec->name, &prop_value);

According to the documentation, g_object_get property allocates memory that must be freed using g_value_unset().

http://www.gtk.org/api/2.6/gobject/gobject-The-Base-Object-Type.html#g-object-get-property

This never happens, causing a memory leak. Below is a valgrind log illustrating the problem. Note the line numbers are slightly different than the line numbers in trunk, but it seems clear what the problem is.

==4864== 790 bytes in 100 blocks are definitely lost in loss record 4,263 of 4,374
==4864== at 0x4C28FAC: malloc (vg_replace_malloc.c:236)
==4864== by 0x77D4A62: g_malloc (gmem.c:164)
==4864== by 0x77ED06D: g_strdup (gstrfuncs.c:102)
==4864== by 0x6F6313F: g_value_set_string (gvaluetypes.c:999)
==4864== by 0x6F3F26B: g_object_get_property (gobject.c:1131)
==4864== by 0xB36AA25: label_notify_cb (parser.c:837)

...rest of trace omitted

Related branches

lp://staging/~ted/libdbusmenu/lp785828
DBus Menu Team: Pending requested
Diff: 13 lines (+3/-0)
1 file modified
libdbusmenu-gtk/parser.c (+3/-0)
DBus Menu Team: Pending requested
Diff: 42 lines (+7/-4)
2 files modified
configure.ac (+4/-4)
libdbusmenu-gtk/parser.c (+3/-0)
lp://staging/~dbusmenu-team/libdbusmenu/ubuntu-0-4
lp://staging/~dbusmenu-team/libdbusmenu/ubuntu
Ken VanDine: Disapprove
Diff: 244 lines (+69/-22)
8 files modified
ChangeLog (+28/-0)
configure (+11/-11)
configure.ac (+3/-3)
debian/changelog (+10/-0)
docs/libdbusmenu-glib/reference/version.xml (+1/-1)
docs/libdbusmenu-gtk/reference/version.xml (+1/-1)
libdbusmenu-gtk/client.c (+14/-6)
libdbusmenu-gtk/genericmenuitem.c (+1/-0)
Ken VanDine: Pending requested
Diff: 67319 lines (+66205/-527)
110 files modified
.bzrignore (+0/-229)
AUTHORS (+17/-0)
ChangeLog (+5918/-0)
Makefile.in (+821/-0)
aclocal.m4 (+10063/-0)
autogen.sh (+0/-12)
compile (+143/-0)
config.guess (+1502/-0)
config.h.in (+86/-0)
config.sub (+1714/-0)
configure (+16483/-0)
debian/changelog (+657/-0)
debian/control (+225/-0)
debian/copyright (+40/-0)
debian/gir1.2-dbusmenu-glib-0.4.install (+1/-0)
debian/gir1.2-dbusmenu-gtk-0.4.install (+1/-0)
debian/gir1.2-dbusmenu-gtk3-0.4.install (+1/-0)
debian/libdbusmenu-glib-dev.install (+6/-0)
debian/libdbusmenu-glib-doc.install (+1/-0)
debian/libdbusmenu-glib3.install (+1/-0)
debian/libdbusmenu-gtk-dev.install (+6/-0)
debian/libdbusmenu-gtk-doc.install (+1/-0)
debian/libdbusmenu-gtk3-3.install (+1/-0)
debian/libdbusmenu-gtk3-dev.install (+5/-0)
debian/libdbusmenu-gtk3.install (+1/-0)
debian/libdbusmenu-jsonloader-dev.install (+4/-0)
debian/libdbusmenu-jsonloader3.install (+1/-0)
debian/libdbusmenu-tools.install (+3/-0)
debian/rules (+45/-0)
debian/source/format (+1/-0)
debian/watch (+2/-0)
depcomp (+630/-0)
docs/Makefile.in (+613/-0)
docs/libdbusmenu-glib/Makefile.in (+613/-0)
docs/libdbusmenu-glib/reference/Makefile.in (+689/-0)
docs/libdbusmenu-glib/reference/html/annotation-glossary.html (+71/-0)
docs/libdbusmenu-glib/reference/html/api-index-full.html (+406/-0)
docs/libdbusmenu-glib/reference/html/ch01.html (+48/-0)
docs/libdbusmenu-glib/reference/html/index.html (+46/-0)
docs/libdbusmenu-glib/reference/html/index.sgml (+120/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClient.html (+427/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClientMenuitem.html (+92/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html (+1326/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitemProxy.html (+154/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuServer.html (+260/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp (+109/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp2 (+109/-0)
docs/libdbusmenu-glib/reference/html/object-tree.html (+32/-0)
docs/libdbusmenu-glib/reference/html/style.css (+266/-0)
docs/libdbusmenu-glib/reference/tmpl/client-menuitem.sgml (+52/-0)
docs/libdbusmenu-glib/reference/tmpl/client.sgml (+168/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem-proxy.sgml (+57/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem.sgml (+520/-0)
docs/libdbusmenu-glib/reference/tmpl/server.sgml (+112/-0)
docs/libdbusmenu-glib/reference/version.xml (+1/-0)
docs/libdbusmenu-glib/reference/xml/annotation-glossary.xml (+64/-0)
docs/libdbusmenu-glib/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-glib/reference/xml/api-index-full.xml (+105/-0)
docs/libdbusmenu-glib/reference/xml/client-menuitem.xml (+70/-0)
docs/libdbusmenu-glib/reference/xml/client.xml (+322/-0)
docs/libdbusmenu-glib/reference/xml/menuitem-proxy.xml (+103/-0)
docs/libdbusmenu-glib/reference/xml/menuitem.xml (+915/-0)
docs/libdbusmenu-glib/reference/xml/server.xml (+199/-0)
docs/libdbusmenu-gtk/Makefile.in (+613/-0)
docs/libdbusmenu-gtk/reference/Makefile.in (+685/-0)
docs/libdbusmenu-gtk/reference/html/api-index-full.html (+122/-0)
docs/libdbusmenu-gtk/reference/html/ch01.html (+42/-0)
docs/libdbusmenu-gtk/reference/html/index.html (+39/-0)
docs/libdbusmenu-gtk/reference/html/index.sgml (+33/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkClient.html (+316/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkMenu.html (+169/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-menuitem.html (+256/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp (+36/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp2 (+36/-0)
docs/libdbusmenu-gtk/reference/html/object-tree.html (+42/-0)
docs/libdbusmenu-gtk/reference/html/style.css (+266/-0)
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk-sections.txt (+70/-0)
docs/libdbusmenu-gtk/reference/libdbusmenu-gtk.types (+3/-0)
docs/libdbusmenu-gtk/reference/tmpl/client.sgml (+115/-0)
docs/libdbusmenu-gtk/reference/tmpl/genericmenuitem.sgml (+22/-0)
docs/libdbusmenu-gtk/reference/tmpl/libdbusmenu-gtk-unused.sgml (+118/-0)
docs/libdbusmenu-gtk/reference/tmpl/menu.sgml (+67/-0)
docs/libdbusmenu-gtk/reference/tmpl/menuitem.sgml (+84/-0)
docs/libdbusmenu-gtk/reference/version.xml (+1/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-full.xml (+33/-0)
docs/libdbusmenu-gtk/reference/xml/client.xml (+214/-0)
docs/libdbusmenu-gtk/reference/xml/genericmenuitem.xml (+36/-0)
docs/libdbusmenu-gtk/reference/xml/menu.xml (+118/-0)
docs/libdbusmenu-gtk/reference/xml/menuitem.xml (+165/-0)
install-sh (+520/-0)
libdbusmenu-glib/Doxyfile (+0/-257)
libdbusmenu-glib/Makefile.in (+958/-0)
libdbusmenu-glib/client-marshal.c (+131/-0)
libdbusmenu-glib/client-marshal.h (+28/-0)
libdbusmenu-glib/dbus-menu-clean.xml.c (+132/-0)
libdbusmenu-glib/dbus-menu-clean.xml.h (+1/-0)
libdbusmenu-glib/menuitem-marshal.c (+170/-0)
libdbusmenu-glib/menuitem-marshal.h (+45/-0)
libdbusmenu-glib/server-marshal.c (+164/-0)
libdbusmenu-glib/server-marshal.h (+36/-0)
libdbusmenu-gtk/Makefile.in (+1005/-0)
ltmain.sh (+8413/-0)
missing (+376/-0)
mkinstalldirs (+162/-0)
po/Makefile.in.in (+217/-0)
tests/Makefile.in (+2204/-0)
tools/Makefile.in (+858/-0)
tools/testapp/CMakeLists.txt (+0/-29)
tools/testapp/Makefile.in (+619/-0)
lp://staging/~ubuntu-desktop/libdbusmenu/ubuntu (Merged)
lp://staging/ubuntu/oneiric/libdbusmenu
lp://staging/ubuntu/natty-proposed/libdbusmenu
Ted Gould (ted)
Changed in dbusmenu:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

This is fixed in oneiric's libdbusmenu, which has 0.4.90.

Changed in libdbusmenu (Ubuntu Oneiric):
status: New → Fix Released
Revision history for this message
Michael Hofmann (mh21) wrote :

Test case:
- get indicator-multiload from: https://launchpad.net/~indicator-multiload/+archive/daily/+sourcepub/1880139/+listing-archive-extra
- launch it from Applications->System Tools->System Load Indicator
- indicator->preferences->refresh interval to 50ms
- quit the indicator (important!)
- launch it again from Applications->System Tools->System Load Indicator
- monitor its memory use with "watch 'ps aux|grep multiload$'"

- with ubuntu3: increase in memory use of 8kB/2s
- with ubuntu4: no increase in memory use

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Michael! This package explicitly has format 1.0 and already has inline patches, so inline patching is fine for this SRU.

Sponsored with corrected upload target, subscribed ubuntu-sru.

Changed in libdbusmenu (Ubuntu Natty):
status: New → Fix Committed
Revision history for this message
Chris Halse Rogers (raof) wrote :

Hm. You've got a stray libdbusmenu-0.4.3/debian/debhelper.log file in the upload. I'm not sure why dh_clean didn't get rid of it, but it should be removed and the package reuploaded. Thanks!

Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 785828] Re: memory leak in label_notify_cb

Chris Halse Rogers [2011-08-24 6:10 -0000]:
> Hm. You've got a stray libdbusmenu-0.4.3/debian/debhelper.log file in
> the upload. I'm not sure why dh_clean didn't get rid of it, but it
> should be removed and the package reuploaded. Thanks!

Chris, the previous package had even more debhelper goo, it's just an
additional line. It might be a debhelper bug, or a bug in the
packaging (although debian/rules is fairly simple), but I did not want
to turn the packaging upside down in an SRU.

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello JKL, or anyone else affected,

Accepted libdbusmenu into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Michael Hofmann (mh21) wrote :

Sorry for the delay, 0.4.3-0ubuntu4 from -proposed solves the problem for me, no other problems after more than a week of testing.

Omer Akram (om26er)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libdbusmenu - 0.4.3-0ubuntu4

---------------
libdbusmenu (0.4.3-0ubuntu4) natty-proposed; urgency=low

  * Backport bug fixes from trunk:
    - Fix memory leak in label_notify_cb (LP: #785828)
 -- Michael Hofmann <email address hidden> Wed, 17 Aug 2011 10:42:58 +0200

Changed in libdbusmenu (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.