vala bindings: undefined reference to `APP_IS_INDICATOR'
Bug #789588 reported by
Michael Hofmann
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity Foundations |
Fix Released
|
Medium
|
Michal Hruby | ||
| libappindicator |
Fix Released
|
Medium
|
Michal Hruby | ||
Bug Description
The vala bindings expect a type check function "APP_IS_INDICATOR", which leads to a compile error for the attached program.
$ valac --pkg=appindica
/tmp/ccT14AUO.o: In function `main_main':
test.vala.
collect2: ld returned 1 exit status
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)
IMHO this is caused by the definition of "App" and "app" as cprefix/
The real type check function has the name "IS_APP_INDICATOR", and a workaround to make the bindings work is to add (type_check_
Related branches
lp://staging/~mhr3/libappindicator/vala-bindings-fix
- Ted Gould (community): Approve
-
Diff: 76 lines (+35/-2)4 files modifiedbindings/vala/Makefile.am (+2/-1)
bindings/vala/appindicator-0.1-custom.vala (+31/-0)
bindings/vala/examples/indicator-example.vala (+1/-0)
configure.ac (+1/-1)
lp://staging/~indicator-applet-developers/libappindicator/ubuntu
- Ken VanDine: Pending requested
-
Diff: 17235 lines (+6462/-3698)43 files modifiedAUTHORS (+1/-0)
ChangeLog (+36/-0)
Makefile.in (+5/-1)
aclocal.m4 (+0/-99)
bindings/Makefile.in (+5/-1)
bindings/mono/Makefile.in (+5/-1)
bindings/mono/examples/Makefile.in (+5/-1)
bindings/python/Makefile.in (+5/-1)
bindings/vala/Makefile.am (+5/-1)
bindings/vala/Makefile.in (+10/-2)
bindings/vala/appindicator-0.1-custom.vala (+31/-0)
bindings/vala/examples/Makefile.in (+5/-1)
bindings/vala/examples/indicator-example.vala (+1/-0)
config.guess (+120/-105)
config.sub (+101/-55)
configure (+1714/-810)
configure.ac (+2/-2)
debian/changelog (+9/-0)
docs/Makefile.in (+5/-1)
docs/reference/Makefile.in (+5/-1)
docs/reference/html/annotation-glossary.html (+2/-2)
docs/reference/html/api-index-deprecated.html (+2/-2)
docs/reference/html/api-index-full.html (+2/-2)
docs/reference/html/ch01.html (+3/-3)
docs/reference/html/index.html (+3/-3)
docs/reference/html/libappindicator-app-indicator.html (+29/-37)
docs/reference/html/libappindicator.devhelp (+0/-80)
docs/reference/html/object-tree.html (+2/-2)
docs/reference/libappindicator-docs.sgml (+1/-1)
docs/reference/tmpl/app-indicator.sgml (+2/-0)
docs/reference/version.xml (+1/-1)
docs/reference/xml/app-indicator.xml (+27/-35)
example/Makefile.in (+5/-1)
example/simple-client-vala.c (+329/-203)
gtk-doc.make (+71/-55)
ltmain.sh (+2619/-1390)
m4/gtk-doc.m4 (+6/-0)
m4/libtool.m4 (+1256/-782)
m4/ltoptions.m4 (+7/-6)
m4/ltversion.m4 (+6/-6)
m4/lt~obsolete.m4 (+9/-3)
src/Makefile.in (+5/-1)
tests/Makefile.in (+5/-1)
- Ken VanDine: Pending requested
-
Diff: 51142 lines (+10848/-18012)96 files modifiedAUTHORS (+5/-0)
ChangeLog (+607/-0)
Makefile.am (+2/-0)
Makefile.in (+7/-1)
aclocal.m4 (+38/-18)
bindings/Makefile.am (+8/-1)
bindings/Makefile.in (+15/-5)
bindings/mono/Makefile.am (+7/-0)
bindings/mono/Makefile.in (+13/-1)
bindings/mono/examples/IndicatorExample.cs (+8/-1)
bindings/mono/examples/Makefile.in (+6/-1)
bindings/mono/libappindicator-api.metadata (+8/-0)
bindings/mono/libappindicator-api.raw (+41/-1)
bindings/python/Makefile.in (+6/-1)
bindings/python/appindicator.defs (+74/-47)
bindings/vala/Makefile.am (+40/-0)
bindings/vala/Makefile.in (+695/-0)
bindings/vala/appindicator-0.1-custom.vala (+31/-0)
bindings/vala/examples/Makefile.am (+39/-0)
bindings/vala/examples/Makefile.in (+604/-0)
bindings/vala/examples/indicator-example.vala (+66/-0)
config.guess (+120/-105)
config.sub (+101/-55)
configure (+2924/-2469)
configure.ac (+36/-33)
debian/changelog (+0/-627)
debian/compat (+0/-1)
debian/control (+0/-129)
debian/copyright (+0/-60)
debian/gir1.2-appindicator-0.1.install (+0/-1)
debian/gir1.2-appindicator3-0.1.install (+1/-0)
debian/libappindicator-dev.install (+0/-5)
debian/libappindicator-doc.install (+0/-1)
debian/libappindicator0.1-cil-dev.install (+0/-1)
debian/libappindicator0.1-cil.install (+0/-1)
debian/libappindicator0.1-cil.installcligac (+0/-3)
debian/libappindicator1.install (+0/-1)
debian/libappindicator1.symbols (+28/-0)
debian/libappindicator3-1.install (+1/-0)
debian/libappindicator3-1.symbols (+28/-0)
debian/libappindicator3-dev.install (+4/-0)
debian/python-appindicator.install (+0/-2)
debian/rules (+0/-93)
debian/watch (+0/-2)
docs/Makefile.in (+6/-1)
docs/reference/Makefile.am (+9/-1)
docs/reference/Makefile.in (+11/-2)
docs/reference/html/annotation-glossary.html (+44/-0)
docs/reference/html/api-index-deprecated.html (+42/-0)
docs/reference/html/api-index-full.html (+0/-253)
docs/reference/html/ch01.html (+0/-34)
docs/reference/html/index.html (+0/-37)
docs/reference/html/index.sgml (+0/-74)
docs/reference/html/libappindicator-app-indicator.html (+0/-1397)
docs/reference/html/libappindicator.devhelp (+0/-68)
docs/reference/html/libappindicator.devhelp2 (+0/-76)
docs/reference/html/object-tree.html (+0/-34)
docs/reference/html/style.css (+0/-265)
docs/reference/libappindicator-docs.sgml (+5/-1)
docs/reference/libappindicator-docs.sgml.in (+4/-0)
docs/reference/libappindicator-sections.txt (+7/-0)
docs/reference/tmpl/app-indicator.sgml (+0/-466)
docs/reference/tmpl/libappindicator-unused.sgml (+36/-0)
docs/reference/version.xml (+1/-1)
docs/reference/xml/annotation-glossary.xml (+26/-0)
docs/reference/xml/api-index-deprecated.xml (+0/-8)
docs/reference/xml/api-index-full.xml (+0/-65)
docs/reference/xml/app-indicator.xml (+0/-1002)
example/Makefile.am (+42/-4)
example/Makefile.in (+78/-15)
example/simple-client-vala.c (+881/-0)
example/simple-client-vala.vala (+181/-0)
example/simple-client.c (+65/-54)
gtk-doc.make (+116/-66)
ltmain.sh (+2619/-1390)
m4/gtk-doc.m4 (+0/-61)
m4/libtool.m4 (+0/-7377)
m4/ltoptions.m4 (+0/-368)
m4/ltsugar.m4 (+0/-123)
m4/ltversion.m4 (+0/-23)
m4/lt~obsolete.m4 (+0/-92)
src/AppIndicator-0.1.metadata.in (+2/-0)
src/AppIndicator3-0.1.metadata.in (+3/-0)
src/Makefile.am (+19/-29)
src/Makefile.in (+38/-60)
src/app-indicator.c (+729/-720)
src/app-indicator.h (+167/-145)
src/appindicator3-0.1.pc.in (+1/-1)
src/application-service-marshal.c (+74/-0)
src/application-service-marshal.list (+2/-0)
src/dbus-shared.h (+3/-3)
src/gen-notification-item.xml.c (+13/-1)
src/notification-item.xml (+13/-1)
tests/Makefile.am (+15/-8)
tests/Makefile.in (+29/-17)
tests/test-libappindicator.desktop (+4/-3)
Revision history for this message
| Michael Hofmann (mh21) wrote | #1 |
Revision history for this message
| Ted Gould (ted) wrote | #2 |
| Changed in libappindicator: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in unity-foundations: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| milestone: | none → oneiric-final |
| Changed in unity-foundations: | |
| assignee: | nobody → Michal Hruby (mhr3) |
| Changed in libappindicator: | |
| assignee: | nobody → Michal Hruby (mhr3) |
| status: | Confirmed → Fix Committed |
| Changed in unity-foundations: | |
| status: | Confirmed → Fix Committed |
| Changed in libappindicator: | |
| milestone: | none → 0.4.0 |
| Changed in libappindicator: | |
| status: | Fix Committed → Fix Released |
| Changed in unity-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've attached a branch which adjusts the example so that it'll confirm this bug. Though, now we need to figure out how to attach the annotation automatically. I also confirmed the fix mentioned in the bug.