Does not work on Python 3.6
Bug #1654334 reported by
Aurélien Bompard
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| lazr.smtptest |
Fix Released
|
Undecided
|
Colin Watson | ||
Bug Description
On Python 3.6, the default value for the 'decode_data' argument in smtpd.SMTPServer changed from True to False. As a result, process_message() gets bytestrings instead of unicode strings and the email.message_
A fix is attached. This parameter was not available in Python 3.4, so the attached patch detects the Python version and sets the parameter if necessary.
Related branches
lp://staging/~cjwatson/lazr.smtptest/py36
- Ioana Lasc (community): Approve
- LAZR Developers: Pending requested
-
Diff: 115 lines (+33/-8)4 files modifiedlazr/smtptest/docs/NEWS.rst (+7/-0)
lazr/smtptest/server.py (+20/-7)
setup.py (+5/-0)
tox.ini (+1/-1)
Revision history for this message
| Aurélien Bompard (abompard) wrote | #1 |
Revision history for this message
| Colin Watson (cjwatson) wrote | #2 |
| Changed in lazr.smtptest: | |
| status: | New → In Progress |
| assignee: | nobody → Colin Watson (cjwatson) |
| Changed in lazr.smtptest: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Colin Watson (cjwatson) wrote | #3 |
| Changed in lazr.smtptest: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think it would be better to pass decode_data=False as of 3.5 and handle the changed process_message signature. I'm preparing a merge proposal to that effect.