representation cache a pessimization
Bug #780835 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| lazr.restful |
Triaged
|
High
|
Unassigned | ||
Bug Description
The lazr restful representation cache is nearly entirely overhead (and disabled on LP prod as a result). Lazr responses are externally cachable - and when a cached response is needed its more efficient to do that outside the lazr stack (e.g. using squid) - doing cache replacement and sizing logic inline in the appserver is a hard problem (particularly as a global view of the cache is not present there).
The complexity of having it adds testing overhead and room for bugs in code (e.g. see launchpad's storm hooks to clear the representation cache).
It may be better to remove it entirely and make the code base smaller.
Related branches
lp://staging/~wgrant/launchpad/no-representationcache
- William Grant (community): Approve (code)
-
Diff: 497 lines (+1/-326)14 files modifiedconfigs/development/launchpad-lazr.conf (+0/-3)
lib/lp/registry/stories/webservice/xx-project-registry.txt (+0/-2)
lib/lp/services/config/schema-lazr.conf (+0/-3)
lib/lp/services/database/sqlbase.py (+0/-6)
lib/lp/services/database/stormbase.py (+0/-6)
lib/lp/services/memcache/doc/restful-cache.txt (+0/-143)
lib/lp/services/memcache/restful.py (+0/-61)
lib/lp/services/memcache/tests/test_doc.py (+0/-1)
lib/lp/services/webservice/configuration.py (+1/-4)
lib/lp/services/webservice/configure.zcml (+0/-5)
lib/lp/services/webservice/stories/cache.txt (+0/-77)
lib/lp/soyuz/stories/webservice/xx-builds.txt (+0/-1)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+0/-2)
lib/lp/testing/pages.py (+0/-12)
| Changed in lazr.restful: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: tech-debt |
| summary: |
- representation cache a pessimism + representation cache a pessimization |
| description: | updated |
| tags: | added: performance |
| tags: | added: easy |
| Changed in lazr.restful: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
| Changed in lazr.restful: | |
| assignee: | William Grant (wgrant) → nobody |
| status: | In Progress → Triaged |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| Changed in lazr.restful: | |
| assignee: | nobody → William Grant (wgrant) |
| tags: | added: qa-needstesting |
| Changed in lazr.restful: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in lazr.restful: | |
| assignee: | William Grant (wgrant) → nobody |
| status: | Fix Committed → Triaged |
To post a comment you must log in.
Fixed in stable r14737 <http://