launchpadlib

base64 decode error

Bug #900307 reported by Brad Crittenden
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpadlib
Fix Released
Critical
Brad Crittenden
python-launchpadlib (Ubuntu)
Fix Released
Undecided
Unassigned
Natty
Fix Released
Undecided
Unassigned
Oneiric
Fix Released
Undecided
Unassigned

Bug Description

The changes for bug 745801 introduced an error in some situations with key rings that aren't easily recognized as plain text. Since the expected 'consumer_key' marker is not present the key is assumed to be base64 encoded and the decoding then fails with 'padding error'.

Francis J. Lacoste (flacoste)
tags: added: fallout
removed: escalated
tags: added: regression
removed: fallout
Revision history for this message
Brad Crittenden (bac) wrote :

Released as 1.9.12 as a Launchpad download tarball and to PyPI.
Fix available at https://launchpad.net/~bac/+archive/ppa for oneiric and precise.

Changed in launchpadlib:
status: Triaged → Fix Committed
Revision history for this message
Brad Crittenden (bac) wrote :

python-launchpadlib now has a daily build at https://launchpad.net/~launchpad/+archive/ppa which includes the fix for this bug.

Changed in launchpadlib:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 900307] Re: base64 decode error

Can you look into pushing a SRU for this into Oneiric?

https://wiki.ubuntu.com/StableReleaseUpdates

--
Martin

Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Brad, or anyone else affected,

Accepted python-launchpadlib into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in python-launchpadlib (Ubuntu Oneiric):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Please make sure this is fiixed in precise ASAP so that once verified this can move to -updates.

Changed in python-launchpadlib (Ubuntu Natty):
status: New → Fix Committed
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hello Brad, or anyone else affected,

Accepted python-launchpadlib into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Brad Crittenden (bac) wrote :

Testing on oneiric the key is being stored as base64 and properly decoded.

tags: added: verification-done-oneiric verification-needed-natty
removed: verification-needed
Revision history for this message
Brad Crittenden (bac) wrote :

And it works as above on natty.

tags: added: verification-done-natty
removed: verification-needed-natty
Clint Byrum (clint-fewbar)
tags: added: verification-done
removed: verification-done-natty verification-done-oneiric
Revision history for this message
Martin Pitt (pitti) wrote :

precise has 1.9.12.

Changed in python-launchpadlib (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-launchpadlib - 1.9.7-0ubuntu2.1

---------------
python-launchpadlib (1.9.7-0ubuntu2.1) natty-proposed; urgency=low

  * Add 100_base64_encode_credentials.patch cherrypicked from upstream
    tree to fix issue causing launchpadlib scripts to fail due to problems
    associated with keyring corruption. We encode launchpadlib's entries so
    the keyring won't be confused by unexpected characters.
     - Convert credentials from unicode when retrieved from the keyring.
       (LP: #877374)
     - Use base 64 encoding for credentials stored in the keyring.
       (LP: #745801)
     - Properly handle decoding base 64.
       (LP: #900307)
 -- Bryce Harrington <email address hidden> Fri, 09 Dec 2011 15:03:01 -0800

Changed in python-launchpadlib (Ubuntu Natty):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-launchpadlib - 1.9.8-2ubuntu0.1

---------------
python-launchpadlib (1.9.8-2ubuntu0.1) oneiric-proposed; urgency=low

  * Add 100_base64_encode_credentials.patch cherrypicked from upstream
    tree to fix issue causing launchpadlib scripts to fail due to problems
    associated with keyring corruption. We encode launchpadlib's entries so
    the keyring won't be confused by unexpected characters.
     - Convert credentials from unicode when retrieved from the keyring.
       (LP: #877374)
     - Use base 64 encoding for credentials stored in the keyring.
       (LP: #745801)
     - Properly handle decoding base 64.
       (LP: #900307)
 -- Bryce Harrington <email address hidden> Fri, 09 Dec 2011 14:55:16 -0800

Changed in python-launchpadlib (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.