Launchpad itself

Launchpad should run with standard_conforming_strings=on in postgresql.conf

Bug #90809 reported by Stuart Bishop
2
Affects Status Importance Assigned to Milestone
Launchpad itself
In Progress
Low
William Grant

Bug Description

We will have trouble with future PostgreSQL upgrades if we continue to send non-SQL standard escaped strings. Most of this should be fixed by upgrading to psycopg2.

Related branches

lp://staging/~stub/launchpad/bug-90809-standard-confirming-strings
lp://staging/~wgrant/launchpad/sqlbase-E-strings
Stuart Bishop (community): Approve
Diff: 414 lines (+53/-53)
4 files modified
lib/lp/bugs/model/tests/test_bugtasksearch.py (+34/-34)
lib/lp/services/database/sqlbase.py (+12/-12)
lib/lp/services/webapp/tests/test_batching.py (+5/-5)
lib/sqlobject/__init__.py (+2/-2)
Stuart Bishop (stub)
Changed in launchpad:
status: Unconfirmed → Confirmed
importance: Undecided → Medium
Revision history for this message
Robert Collins (lifeless) wrote :

Where are we at on this?

Changed in launchpad:
importance: Medium → High
assignee: nobody → Stuart Bishop (stub)
Stuart Bishop (stub)
tags: added: pg9
Stuart Bishop (stub)
Changed in launchpad:
importance: High → Low
Stuart Bishop (stub)
tags: removed: pg9
tags: added: pg9
Revision history for this message
Stuart Bishop (stub) wrote :

I was going to do this as part of the pg 9 migration, but there is quite a bit of fallout. We will deal with standard_confirming_strings separately, so any fallout from pg 9 or standard_confirming_strings is correctly attributed.

There are two major areas I've seen where we expect plain quoted strings to accept backslash quoting:
 - regular expressions
 - accidental binary -> text casting. In particular, byte strings passed to Storm are sent as binary and at some point this is being reassembled to text. We should be passing Unicode, but we don't notice.

William Grant (wgrant)
Changed in launchpad:
assignee: Stuart Bishop (stub) → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17381 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17381) is part of this bug's fix.

tags: added: qa-needstesting
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.