Launchpad itself

ArchivePermission allows duplicated rows

Bug #887185 reported by Julian Edwards
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Colin Watson

Bug Description

This is fine until you come to delete one and you get a NotOneError.

Example:
launchpad_prod_3=# select * from archivepermission where packageset=109;
 id | date_created | person | permission | archive | component | sourcepackagename | packageset | explicit
-----+----------------------------+---------+------------+---------+-----------+-------------------+------------+----------
 769 | 2011-11-03 19:37:40.072146 | 3666300 | 1 | 1 | | | 109 | f
 755 | 2011-10-13 14:45:10.404165 | 16139 | 1 | 1 | | | 109 | f
 731 | 2011-10-13 14:45:10.404165 | 16139 | 1 | 1 | | | 109 | f

Related branches

lp://staging/~cjwatson/launchpad/init-packageset-fixes
William Grant (community): Approve (code)
Diff: 99 lines (+53/-9)
2 files modified
lib/lp/soyuz/scripts/initialize_distroseries.py (+3/-5)
lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py (+50/-4)
lp://staging/~cjwatson/launchpad/archive-permission-sampledata
William Grant (community): Approve (code)
Diff: 36 lines (+1/-3)
3 files modified
database/sampledata/current-dev.sql (+0/-1)
database/sampledata/current.sql (+0/-1)
lib/lp/soyuz/doc/archivepermission.txt (+1/-1)
Julian Edwards (julian-edwards)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
tags: added: packagesets
tags: added: soyuz-upload
Revision history for this message
Raphaël Badin (rvb) wrote :

I've checked ubuntu/oneiric and ubuntu-leb/oneiric: no other duplication.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Precise has got *many* duplicated permissions for its packagesets and the timestamps are all at the time that precise was initialised. This means there's a bug in initialize-distroseries.py.

Changed in launchpad:
importance: High → Critical
assignee: nobody → Launchpad Red Squad (redsquad)
Revision history for this message
Colin Watson (cjwatson) wrote :

I have a test exercising this behaviour and am working on a fix, hopefully in time for initialising Q.

Changed in launchpad:
assignee: Launchpad Red Squad (redsquad) → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
William Grant (wgrant) wrote :

https://pastebin.canonical.com/64714/ is an analysis of the broken production data.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15137 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15137) is part of this bug's fix.

tags: added: qa-needstesting
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15145 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15145) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
William Grant (wgrant)
tags: added: qa-untestable
removed: qa-needstesting
Gavin Panella (allenap)
Changed in launchpad:
status: In Progress → Fix Released
Revision history for this message
Stéphane Graber (stgraber) wrote :

Filed bug 1025441 to clear the remaining duplicates from the DB.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.