[http] double slash in request causes 404 for valid repositories
Bug #854647 reported by
Jelmer Vernooij
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Dulwich |
Fix Released
|
High
|
Jelmer Vernooij | ||
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
using a double slash in a request can cause some git http servers to reply with a 404, even if the URL would otherwise be valid.
dulwich should make sure to not add a slash if there is already one present at the end of a URL.
Related branches
lp://staging/~jelmer/launchpad/dulwich-fix-double-slash
- William Grant (community): Approve (code)
-
Diff: 42 lines (+6/-6)2 files modifiedutilities/sourcedeps.cache (+4/-4)
utilities/sourcedeps.conf (+2/-2)
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| William Grant (wgrant) wrote | #2 |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #3 |
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | #4 |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #5 |
Revision history for this message
| Daniel Holbach (dholbach) wrote | #6 |
| Changed in dulwich: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → 0.8.1 |
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | #7 |
| Changed in launchpad: | |
| assignee: | Jelmer Vernooij (jelmer) → nobody |
| status: | In Progress → Triaged |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| status: | In Progress → Triaged |
| assignee: | Jelmer Vernooij (jelmer) → nobody |
| tags: | added: code-import git |
| tags: | removed: qa-ok |
To post a comment you must log in.
Fixed in stable r14001 <http://