Block merge proposals on VCS imported/mirrored branches
Bug #834525 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
Many people mistakenly propose merges against branches that LP is mirroring from another VCS. Since we can do nothing but reject them, we should block the proposal in the first place.
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: code-import code-review |
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 834525] [NEW] Block merge proposals on VCS imported/mirrored branches | #1 |
To post a comment you must log in.
I have seen this happen too. Sometimes there is a useful conversation
on the mp and it gets resolved.
At the point people propose the merge, they've presumably already done
some work in another branch, and the mp is a way to get that work
finished off and integrated: it can be merged into an imported branch
using a bzr foreign-branch plugin or just by taking the diff from the
mp. So although there is a trap here, there is also something
potentially useful.
Some things we could do:
* give a warning if the target is an import, rather than blocking it
* more generally, give a warning in cases where the owner of the
target branch is not likely to see the mp creation in launchpad
* make it easier to get the whole diff out of a mp (there's a
separate bug for it being unobvious that you can just download the
diff)