Do not set style directly in structural-subscriptions.js
Bug #752406 reported by
Данило Шеган
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
High
|
Unassigned |
Bug Description
In lib/lp/
tags: | added: story-better-bug-notification |
tags: | added: tech-debt |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Medium |
importance: | Medium → High |
Changed in launchpad: | |
importance: | Low → Medium |
Changed in launchpad: | |
importance: | Medium → High |
tags: | added: javascript |
To post a comment you must log in.
I wonder about the importance/wisdom of this policy in one-location-JS-app code like this. The class will not be shared; and the application of the style locally follows DRY because of how we do it; and IMO making it as a CSS class in the shared launchpad CSS will make it harder, not easier, to refactor the JS.
Because of this, and because a "high" bug blocks us from declaring that we are done with our LEP, I'm reducing this to low. I'm tempted to even mark this as Won't Fix and see who argues back, but I suspect this comment will already accomplish the purpose of getting dissenting or agreeing replies.