BugNomination:+edit-form structural subscriptions taking 4.8 seconds during nomination editing POST
Bug #723999 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Yellow Squad |
Bug Description
OOPS-1880K1665
HTTP method: POST
URL: https:/
Branch: launchpad-rev-12432
Revno: 12432
SQL time: 11979 ms
Non-sql time: 2622 ms
Total time: 14601 ms
Statement Count: 367
4 -very- long queries, both long to copy and long to execute are taking up 4.8 seconds on this page on their own. This may be related to the number of subscribers - I haven't analysed the query plans.
On top of that, lots of late evaluation of email addresses - with a total of 483ms for that.
Related branches
lp://staging/~gary/launchpad/bug723999
- j.c.sackett (community): Approve
-
Diff: 1058 lines (+474/-351)5 files modifiedlib/lp/bugs/model/bug.py (+15/-37)
lib/lp/bugs/model/bugtask.py (+14/-69)
lib/lp/bugs/model/structuralsubscription.py (+418/-237)
lib/lp/bugs/model/tests/test_bugtask.py (+5/-3)
lib/lp/bugs/tests/test_structuralsubscriptiontarget.py (+22/-5)
description: | updated |
description: | updated |
Changed in launchpad: | |
assignee: | nobody → Launchpad Yellow Squad (yellow) |
tags: | added: story-better-bug-notification |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm fairly sure this comes from code in lp.bugs. model.structura lsubscription. BugFilterSetBui lder.
To satisfy my own curiosity, some small hand-made stats about the long queries.
- There are four verrrry similar long queries, each taking between 1 and 1.5 seconds. They may (hopefully) differ in the variables they use when they are called. I wouldn't be surprised if the four are looking at different duped bugs.
- Each unions query unions three distinct select statements, each of which is repeated several times. In the first long query, for instance, the first and second are *each* repeated (unioned) five times; the last is repeated four times. Other long queries apparently vary this somewhat (the second has five, five, and one), but the three unioned queries are identical across all four long queries.