contrib/oauth.py should be removed
Bug #701545 reported by
Martin Pool
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Colin Watson |
Bug Description
contrib/oauth.py seems to be redundant with a library that's also available in Ubuntu and maybe in sourcecode, and it's an old buggy version. (See bug 314507.) We should check for any local changes that need to be removed, delete it, and check nothing breaks.
Related branches
lp://staging/~mbp/launchpad/701545-oauth
Rejected
for merging
into
lp://staging/launchpad
- Curtis Hovey (community): Approve (code)
- j.c.sackett: Pending (code*) requested
-
Diff: 624 lines (+9/-537)6 files modifiedlib/canonical/launchpad/webapp/authentication.py (+2/-2)
lib/canonical/launchpad/webapp/tests/test_authentication.py (+5/-2)
lib/canonical/launchpad/webapp/tests/test_publication.py (+2/-2)
lib/contrib/oauth.py (+0/-529)
setup.py (+0/-1)
versions.cfg (+0/-1)
lp://staging/~mbp/meta-lp-deps/701545-add-dependency
Rejected
for merging
into
lp://staging/meta-lp-deps
- Launchpad code reviewers: Pending requested
-
Diff: 26 lines (+8/-0)2 files modifieddebian/changelog (+7/-0)
debian/control (+1/-0)
~cjwatson/launchpad:oauthlib
Merged
into
launchpad:master
- Tom Wardill (community): Approve
-
Diff: 750 lines (+44/-587)6 files modifieddev/null (+0/-536)
lib/lp/services/webapp/authentication.py (+12/-5)
lib/lp/services/webapp/tests/test_authentication.py (+10/-8)
lib/lp/services/webapp/tests/test_publication.py (+11/-16)
lib/lp/testing/pages.py (+10/-22)
setup.py (+1/-0)
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
milestone: | 11.02 → 11.03 |
Changed in launchpad: | |
status: | Triaged → In Progress |
Changed in launchpad: | |
assignee: | Martin Pool (mbp) → nobody |
tags: | removed: qa-untestable |
To post a comment you must log in.
I looked at the bzr history of this file. The only change since it was copied into the tree (on 2008-04-01) was my fix for bug 314507.
There is already a later oauth egg in lp-sourcedeps.
So it's basically a typo test: just delete the file, then see if that passes qa.